| Summary: | [chromium] WebFilterOperations API does not compile or dynamically link | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dana Jansens <danakj> | ||||||||
| Component: | New Bugs | Assignee: | Dana Jansens <danakj> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, backer, dglazkov, fishd, jamesr, piman, tkent+wkapi, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Dana Jansens
2012-04-20 16:03:12 PDT
Created attachment 138184 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Attachment 138184 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 138185 [details]
Patch
Comment on attachment 138185 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138185&action=review > Source/Platform/ChangeLog:3 > + [chromium] Fix API for WebFilterOperations this isn't a terribly useful title - maybe say something about what you're exporting? Created attachment 138192 [details]
Patch
true say, fixed.
Comment on attachment 138192 [details] Patch Clearing flags on attachment: 138192 Committed r114807: <http://trac.webkit.org/changeset/114807> All reviewed patches have been landed. Closing bug. |