| Summary: | PageGroupLoadDeferrer needs to take a ReasonForSuspension argument | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
| Component: | Page Loading | Assignee: | Brady Eidson <beidson> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, jchaffraix, yong.li.webkit | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 84488 | ||||||
| Attachments: |
|
||||||
Created attachment 138162 [details]
Patch v1 - Refactor to add a ReasonForSuspension argument
Comment on attachment 138162 [details] Patch v1 - Refactor to add a ReasonForSuspension argument View in context: https://bugs.webkit.org/attachment.cgi?id=138162&action=review > Source/WebCore/dom/Document.h:1486 > + bool m_suspendedScheduledTasks; m_suspendedScheduledTasks sounds like it would be a container for suspended scheduled tasks. Maybe m_scheduledTasksAreSuspended or something that indicates that it's a boolean? (In reply to comment #2) > (From update of attachment 138162 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138162&action=review > > > Source/WebCore/dom/Document.h:1486 > > + bool m_suspendedScheduledTasks; > > m_suspendedScheduledTasks sounds like it would be a container for suspended scheduled tasks. Maybe m_scheduledTasksAreSuspended or something that indicates that it's a boolean? Sounds good. Thanks! |
PageGroupLoadDeferrer needs to take a ReasonForSuspension argument There's a long standing comment: // NOTE: if PageGroupLoadDeferrer is ever used for tasks other than showing a modal window or sheet, // the constructor will need to take a ActiveDOMObject::ReasonForSuspension. As we resolve https://bugs.webkit.org/show_bug.cgi?id=84488 that comment is no longer a suggestion towards some vague future. Also relevant to radar <rdar://problem/10484294>