|Summary:||JSGarbageCollect should not call collectAllGarbage()|
|Product:||WebKit||Reporter:||Mark Hahnenberg <mhahnenberg>|
|Version:||528+ (Nightly build)|
Description Mark Hahnenberg 2012-04-20 12:09:18 PDT
JSGarbageCollect should not synchronously call collectAllGarbage(). Instead, it should notify the GCActivityCallback that it has abandoned an object graph, which will set the timer to run at some point in the future that JSC can decide according to its own policies.
Comment 2 Geoffrey Garen 2012-04-20 12:17:14 PDT
Comment on attachment 138139 [details] Patch Let's fix the FIXME by taking advantage of our new callback, like so: - Cancel the GC timer at the start of collection (rename didCollect to willCollect) - If collection causes a didAbandonObjectGraph, it can now start the timer, which will, in fact, cause another collection later. In the same patch, you can remove the isBusy() check, since didAbandonObjectGraph is safe to call while the heap is busy.