Bug 84432
| Summary: | Layout Tests fast/filesystem/* are failing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mikhail Naganov <mnaganov> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, dimich, kinuko, mnaganov, noel.gordon |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
Mikhail Naganov
The following layout tests are failing on Chromium Windows
fast/filesystem/op-restricted-unicode.html
fast/filesystem/op-restricted-names.html
fast/filesystem/read-directory.html
fast/filesystem/simple-readonly-file-object.html
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Ffilesystem%2Fop-restricted-names.html%2Cfast%2Ffilesystem%2Fop-restricted-unicode.html%2Cfast%2Ffilesystem%2Fread-directory.html%2Cfast%2Ffilesystem%2Fsimple-readonly-file-object.html
Probable cause:
See the layout test results: http://build.chromium.org/buildbot/layout_test_results/Webkit_Win7/133172
Tests terminate with errors
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kinuko Yasuda
http://src.chromium.org/viewvc/chrome?view=rev&revision=165018 must have resolved the issue!
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Ffilesystem
noel gordon
One of you might flip a coin: the winner could rebase (rather than leave the results failing for a month).
noel gordon
http://trac.webkit.org/changeset/137257
Chris Dumez
Committed r137259: <http://trac.webkit.org/changeset/137259>
noel gordon
@christophe.dumez that last commit doesn't look right to me.
noel gordon
And to be clear, I mean http://trac.webkit.org/changeset/137259 was not a patch from me.
Chris Dumez
(In reply to comment #6)
> And to be clear, I mean http://trac.webkit.org/changeset/137259 was not a patch from me.
Yes, I'm not sure what happened. I used webkit-patch to land my change and it somehow used the wrong changelog entry for the commit.
What can I do?
noel gordon
(In reply to comment #7)
> Yes, I'm not sure what happened. I used webkit-patch to land my change and it somehow used the wrong changelog entry for the commit.
Our fingers are synchronized :)
> What can I do?
Two options: 1) Roll out, and resubmit again with the right ChangeLog, or 2) Correct the ChangeLog and land that manually. 1) is easy :)