improvements to Cocoa bindings support in WebView - code simplification

• Component: WebKit API
• Status: RESOLVED FIXED

[James G. Speth]

here are some improvements to the Cocoa bindings support in WebView from bug #8389.  primarily, this removes the WebController class altogether.  the WebController isn't needed anymore, since i figured out how to make the NSTreeController and WebView work well together without it.  now you can just bind the contentObject binding of the tree controller directly to the mainFrameDocument key of the WebView.

[Eric Seidel (no email)]

It looks like you forgot to attach the patch :(

[James G. Speth]

Created attachment 7777 [details]
patch removing the WebController and using better simpler KVO notifications

[Darin Adler]

Comment on attachment 7777 [details]
patch removing the WebController and using better simpler KVO notifications

Won't removing the WebController break compatibility?

[Timothy Hatcher]

WebController was recently added (this weekend.) It wasn't needed for any functionality, but NSTreeController workarounds.  A user can just use NSTreeController with this patch.

[James G. Speth]

Created attachment 7788 [details]
new patch with comments

i also moved the call to stop returning the DOMDocument from the beginning of the loading process to the point where the load is committed.  it feels better this way when using it, since it's more synchronized with the WebView's state.

[Timothy Hatcher]

Comment on attachment 7788 [details]
new patch with comments

This looks good. r=me

[Timothy Hatcher]

Landed in r13980.