Summary: | setPageScaleFactor should setScrollPosition if scale is unchanged | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexandre Elias <aelias> | ||||||||||
Component: | New Bugs | Assignee: | Alexandre Elias <aelias> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, aelias, dglazkov, eric, fsamuel, kenneth, peter, simon.fraser, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 66687 | ||||||||||||
Attachments: |
|
Description
Alexandre Elias
2012-04-19 16:23:03 PDT
Created attachment 138001 [details]
Patch
Comment on attachment 138001 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138001&action=review Looks good, but a better explanation for the lack of tests is needed > Source/WebCore/ChangeLog:14 > + No new tests. Why? Created attachment 138198 [details]
Patch
OK, I added a layout test case. Comment on attachment 138198 [details] Patch Attachment 138198 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12482328 New failing tests: fast/events/scale-and-scroll-body.html Created attachment 138213 [details]
Archive of layout-test-results from ec2-cr-linux-04
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 138218 [details]
Patch
Comment on attachment 138218 [details]
Patch
Based on kenneth's comment below and the new test, it looks like this is ready to go. Thanks.
Comment on attachment 138218 [details] Patch Clearing flags on attachment: 138218 Committed r116574: <http://trac.webkit.org/changeset/116574> All reviewed patches have been landed. Closing bug. Do all ports have this bug and it just hasn't been noticed before? |