|Summary:||New ruby tests broken on Mac|
|Product:||WebKit||Reporter:||Ken Buchanan <kenrb>|
|Component:||Layout and Rendering||Assignee:||Ken Buchanan <kenrb>|
|Severity:||Normal||CC:||dimich, eric, jer.noble, rolandsteiner, simon.fraser, webkit.review.bot|
|Version:||528+ (Nightly build)|
Description Ken Buchanan 2012-04-19 14:23:50 PDT
Two new tests that recently landed are failing with text diffs on Mac: http://trac.webkit.org/changeset/114666 There is a one pixel height difference. Apparently I need a minor tweak to make these tests work cross-platform with the same results. http://build.webkit.org/results/Lion%20Release%20(Tests)/r114666%20(7766)/results.html
Comment 3 Ken Buchanan 2012-04-19 14:55:16 PDT
Patch update is just because I accidentally had +x on the expectation files.
Comment 4 Ken Buchanan 2012-04-19 15:02:18 PDT
smfr can you review this?
Comment 5 Simon Fraser (smfr) 2012-04-19 15:10:19 PDT
Is this equivalent to what jer did in http://trac.webkit.org/changeset/114674?
Comment 6 Eric Seidel (no email) 2012-04-19 15:12:01 PDT
Comment on attachment 137983 [details] Patch OK.
Comment 7 WebKit Review Bot 2012-04-19 15:49:22 PDT
Comment on attachment 137983 [details] Patch Clearing flags on attachment: 137983 Committed r114685: <http://trac.webkit.org/changeset/114685>
Comment 8 WebKit Review Bot 2012-04-19 15:49:28 PDT
All reviewed patches have been landed. Closing bug.
Comment 9 Ken Buchanan 2012-04-19 18:29:10 PDT
Ugh, I didn't see http://trac.webkit.org/changeset/114674 go in. That provides new Mac baselines, but I updated the tests to provide non-platform specific results. This will be fixed if 114674 gets rolled out, it looks like. The actual results match the expectations I provided in my patch: http://build.webkit.org/results/Lion%20Release%20%28Tests%29/r114685%20%287772%29/results.html