Bug 84376

Summary: [Chromium] Call memoryUsageMB directly
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, fishd, haraken, japhet, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82948    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Mark Pilgrim (Google) 2012-04-19 13:19:26 PDT 
[Chromium] Call memoryUsageMB directly
Comment 1 Mark Pilgrim (Google) 2012-04-19 13:22:49 PDT 
Created attachment 137964 [details]
Patch
Comment 2 Mark Pilgrim (Google) 2012-04-19 13:24:00 PDT 
This adds new files to WebKit, so we'll need to wait for the EWS bots to tell us if I screwed that part up.
Comment 3 Build Bot 2012-04-19 13:27:50 PDT 
Comment on attachment 137964 [details]
Patch

Attachment 137964 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12442306
Comment 4 Early Warning System Bot 2012-04-19 13:30:22 PDT 
Comment on attachment 137964 [details]
Patch

Attachment 137964 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12458029
Comment 5 Early Warning System Bot 2012-04-19 13:31:24 PDT 
Comment on attachment 137964 [details]
Patch

Attachment 137964 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12428710
Comment 6 Build Bot 2012-04-19 13:39:52 PDT 
Comment on attachment 137964 [details]
Patch

Attachment 137964 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12297418
Comment 7 Mark Pilgrim (Google) 2012-04-19 14:00:31 PDT 
Well I guess that answers that question.
Comment 8 Eric Seidel (no email) 2012-04-19 14:13:53 PDT 
Comment on attachment 137964 [details]
Patch

The EWS bots are sad.
Comment 9 Mark Pilgrim (Google) 2012-04-19 19:02:16 PDT 
Created attachment 138025 [details]
Patch
Comment 10 Kentaro Hara 2012-04-20 01:26:50 PDT 
Comment on attachment 138025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138025&action=review

> Source/WebCore/platform/chromium/MemoryUsageSupportChromium.cpp:39
> +// Returns the current space allocated for the pagefile, in MB.
> +// That is committed size for Windows and virtual memory size for POSIX

Nit: Put this comment in the header file.

Nit: The trailing period please. "for POSIX."
Comment 11 Mark Pilgrim (Google) 2012-04-20 14:58:13 PDT 
Created attachment 138172 [details]
Patch
Comment 12 Mark Pilgrim (Google) 2012-04-20 14:58:40 PDT 
Comment on attachment 138172 [details]
Patch

Nits addressed.
Comment 13 Kentaro Hara 2012-04-20 15:04:21 PDT 
Comment on attachment 138172 [details]
Patch

OK
Comment 14 WebKit Review Bot 2012-04-20 16:31:43 PDT 
Comment on attachment 138172 [details]
Patch

Clearing flags on attachment: 138172

Committed r114797: <http://trac.webkit.org/changeset/114797>
Comment 15 WebKit Review Bot 2012-04-20 16:31:59 PDT 
All reviewed patches have been landed.  Closing bug.