Bug 84358

Summary: Web Inspector: exception when hovering object while paused
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch vsevik: review+

Description Yury Semikhatsky 2012-04-19 11:06:46 PDT
"Protocol Error: Invalid type of argument 'returnByValue' for method 'Debugger.evaluateOnCallFrame' call. It must be 'boolean' but it is 'function'.", source: chrome-devtools://devtools/InspectorBackend.js (113)
Comment 1 Yury Semikhatsky 2012-04-19 11:09:54 PDT
Created attachment 137924 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-04-19 11:11:39 PDT
Comment on attachment 137924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137924&action=review

> Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:283
> +        selectedCallFrame.evaluate(this._highlightElement.textContent, objectGroupName, false, false, false, showObjectPopover.bind(this));

It should be true.
Comment 3 Yury Semikhatsky 2012-04-19 11:13:05 PDT
(In reply to comment #2)
> (From update of attachment 137924 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=137924&action=review
> 
> > Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:283
> > +        selectedCallFrame.evaluate(this._highlightElement.textContent, objectGroupName, false, false, false, showObjectPopover.bind(this));
> 
> It should be true.

Done.
Comment 4 Yury Semikhatsky 2012-04-19 11:18:26 PDT
Committed r114654: <http://trac.webkit.org/changeset/114654>