Bug 84280

Summary: IndexedDB: Stub out IDBCursor.advance for landing
Product: WebKit Reporter: Alec Flett <alecflett>
Component: New BugsAssignee: Alec Flett <alecflett>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84174    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Alec Flett 2012-04-18 14:29:24 PDT 
IndexedDB: Stub out IDBCursor.advance for landing
Comment 1 Alec Flett 2012-04-18 14:30:30 PDT 
Created attachment 137770 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-18 14:34:54 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Alec Flett 2012-04-18 15:25:04 PDT 
Created attachment 137781 [details]
Patch
Comment 4 Alec Flett 2012-04-18 15:26:09 PDT 
Created attachment 137782 [details]
Patch
Comment 5 Alec Flett 2012-04-18 15:26:42 PDT 
ok, took a few tries, but this is pretty now.

dglazkov@ - r? cq?
Comment 6 Dimitri Glazkov (Google) 2012-04-19 09:17:13 PDT 
Comment on attachment 137782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137782&action=review

> Source/WebKit/chromium/ChangeLog:8
> +        Just a stub method so it can be implemented on chromium

Would love to have a period at the end of this sentence :)
Comment 7 WebKit Review Bot 2012-04-19 10:05:52 PDT 
Comment on attachment 137782 [details]
Patch

Clearing flags on attachment: 137782

Committed r114647: <http://trac.webkit.org/changeset/114647>
Comment 8 WebKit Review Bot 2012-04-19 10:05:57 PDT 
All reviewed patches have been landed.  Closing bug.