Bug 84257

Summary:

[V8][Refactoring] Remove V8Proxy::toV8()

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

84074

Attachments:

Description	Flags
Patch	none

Description Kentaro Hara 2012-04-18 11:05:32 PDT

Some constructorCallback()s are using V8Proxy::toV8(), other constructorCallback()s are directly using setJSWrapperForXXX() (XXX can be DOMObject, ActiveDOMObject, Node or ActiveNode). We should unify them.

Considering the fact that V8Proxy::toV8() just supports XXX=DOMObject and thus is not flexible, replacing V8Proxy::toV8() with setJSWrapperForXXX() would make sense.

Comment 1 Kentaro Hara 2012-04-18 11:10:11 PDT

Created attachment 137726 [details]
Patch

Comment 2 WebKit Review Bot 2012-04-23 11:33:19 PDT

Comment on attachment 137726 [details]
Patch

Clearing flags on attachment: 137726

Committed r114922: <http://trac.webkit.org/changeset/114922>

Comment 3 WebKit Review Bot 2012-04-23 11:33:24 PDT

All reviewed patches have been landed.  Closing bug.