Bug 84238

Summary:

Unimplemented methods in Windows API

Product:

WebKit

Reporter:

George Tsoumalis <tsumalis96>

Component:

WebKit API

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adele, eric, jberlin, jhoneycutt, lforschler, roger_fong, sfalken, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
Patch for WebMutableURLRequest	none
Patch for WebMutableURLRequest (Revised)	none
Patch for WebMutableURLRequest (Revised)	none
Patch for WebMutableURLRequest (Revised)	buildbot: commit-queue-
Patch for WebMutableURLRequest (Revised)	none

George Tsoumalis

Reported 2012-04-18 06:29:45 PDT

In this bug report I will try to post patches for as many unimplemented methods as possible inside the WebKit API for Windows

Attachments
Patch for WebMutableURLRequest (2.32 KB, patch) 2012-04-18 07:14 PDT, George Tsoumalis	no flags	Details Formatted Diff Diff
Patch for WebMutableURLRequest (Revised) (2.44 KB, patch) 2012-04-18 07:18 PDT, George Tsoumalis	no flags	Details Formatted Diff Diff
Patch for WebMutableURLRequest (Revised) (2.44 KB, patch) 2012-04-18 07:37 PDT, George Tsoumalis	no flags	Details Formatted Diff Diff
Patch for WebMutableURLRequest (Revised) (2.32 KB, patch) 2012-04-18 07:48 PDT, George Tsoumalis	buildbot: commit-queue-	Details Formatted Diff Diff
Patch for WebMutableURLRequest (Revised) (2.32 KB, patch) 2012-04-18 08:13 PDT, George Tsoumalis	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

George Tsoumalis

Comment 1 2012-04-18 07:14:24 PDT

Created attachment 137681 [details] Patch for WebMutableURLRequest

George Tsoumalis

Comment 2 2012-04-18 07:18:09 PDT

Created attachment 137682 [details] Patch for WebMutableURLRequest (Revised)

WebKit Review Bot

Comment 3 2012-04-18 07:21:41 PDT

Attachment 137682 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/win/WebMutableURLRequest.cpp:191: Tab found; better to use spaces [whitespace/tab] [1] Source/WebKit/win/WebMutableURLRequest.cpp:192: Tab found; better to use spaces [whitespace/tab] [1] Source/WebKit/win/WebMutableURLRequest.cpp:193: Tab found; better to use spaces [whitespace/tab] [1] Source/WebKit/win/WebMutableURLRequest.cpp:195: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebKit/win/WebMutableURLRequest.cpp:196: Tab found; better to use spaces [whitespace/tab] [1] Source/WebKit/win/WebMutableURLRequest.cpp:197: Tab found; better to use spaces [whitespace/tab] [1] Source/WebKit/win/WebMutableURLRequest.cpp:198: Tab found; better to use spaces [whitespace/tab] [1] Source/WebKit/win/WebMutableURLRequest.cpp:278: Tab found; better to use spaces [whitespace/tab] [1] Source/WebKit/win/WebMutableURLRequest.cpp:279: Tab found; better to use spaces [whitespace/tab] [1] Source/WebKit/win/WebMutableURLRequest.cpp:280: Tab found; better to use spaces [whitespace/tab] [1] Source/WebKit/win/WebMutableURLRequest.cpp:330: Tab found; better to use spaces [whitespace/tab] [1] Source/WebKit/win/WebMutableURLRequest.cpp:331: Tab found; better to use spaces [whitespace/tab] [1] Source/WebKit/win/WebMutableURLRequest.cpp:332: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 13 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

George Tsoumalis

Comment 4 2012-04-18 07:37:31 PDT

Created attachment 137683 [details] Patch for WebMutableURLRequest (Revised)

George Tsoumalis

Comment 5 2012-04-18 07:48:04 PDT

Created attachment 137685 [details] Patch for WebMutableURLRequest (Revised)

Build Bot

Comment 6 2012-04-18 08:10:36 PDT

Comment on attachment 137685 [details] Patch for WebMutableURLRequest (Revised) Attachment 137685 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12426310

George Tsoumalis

Comment 7 2012-04-18 08:13:39 PDT

Created attachment 137691 [details] Patch for WebMutableURLRequest (Revised)

Eric Seidel (no email)

Comment 8 2012-08-22 15:32:51 PDT

I believe this is Apple's API, so they should review this.

Jessie Berlin

Comment 9 2012-08-23 08:49:49 PDT

Is there an actual need for these APIs to be implemented (e.g. do they make any tests start working on Windows)?

Brent Fulgham

Comment 10 2012-11-13 23:56:37 PST

Comment on attachment 137691 [details] Patch for WebMutableURLRequest (Revised) These changes seem useful and correct. I'm approving them, but please back them out if they introduce any test failures.

WebKit Review Bot

Comment 11 2012-11-14 00:04:35 PST

Comment on attachment 137691 [details] Patch for WebMutableURLRequest (Revised) Clearing flags on attachment: 137691 Committed r134559: <http://trac.webkit.org/changeset/134559>

WebKit Review Bot

Comment 12 2012-11-14 00:04:40 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.