Summary: | [V8] Add an optional Isolate argument to wrap() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||
Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dglazkov, eric.carlson, feature-media-reviews, japhet, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 84074 | ||||||||
Attachments: |
|
Description
Kentaro Hara
2012-04-17 15:32:28 PDT
Created attachment 137620 [details]
Patch
Attachment 137620 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.h:43: The parameter name "isolate" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.h:44: The parameter name "isolate" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h:45: The parameter name "isolate" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/scripts/test/V8/V8TestNode.h:43: The parameter name "isolate" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/scripts/test/V8/V8Float64Array.h:44: The parameter name "isolate" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/scripts/test/V8/V8TestObj.h:43: The parameter name "isolate" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.h:49: The parameter name "isolate" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h:43: The parameter name "isolate" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.h:43: The parameter name "isolate" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.h:43: The parameter name "isolate" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:45: The parameter name "isolate" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 11 in 18 files
If any of these errors are false positives, please file a bug against check-webkit-style.
All bots got green. The style error seems false positive (We want to write the default value in the header). Review? Comment on attachment 137620 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137620&action=review >> Source/WebCore/bindings/scripts/test/V8/V8Float64Array.h:44 >> + inline static v8::Handle<v8::Object> wrap(Float64Array*, v8::Isolate* isolate = 0); > > The parameter name "isolate" adds no information, so it should be removed. [readability/parameter_name] [5] It's objecting to the variable name, not the assignment. I believe you can change this to "v8::Isolate* = 0"? Committed r114519: <http://trac.webkit.org/changeset/114519> (In reply to comment #4) > It's objecting to the variable name, not the assignment. I believe you can change this to "v8::Isolate* = 0"? Fixed. Thanks for reviews! Reverted r114519 for reason: Chromium crash Committed r114730: <http://trac.webkit.org/changeset/114730> Created attachment 138367 [details]
Patch for relanding. It is revealed that the patch was innocent.
Committed r114911: <http://trac.webkit.org/changeset/114911> |