Summary: | run-webkit-tests picked up an old crash log | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | Tools / Tests | Assignee: | Dirk Pranke <dpranke> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dpranke, eric, lforschler, ojan, rniwa, simon.fraser, thorton, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
URL: | http://build.webkit.org/results/Lion%20Debug%20(WebKit2%20Tests)/r114380%20(6092)/fast/loader/form-state-restore-with-locked-back-forward-list-crash-log.txt | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2012-04-17 14:49:49 PDT
Good point. It should be easy enough to change the code to notice when run-webkit-tests starts and not pick up any crash logs older than that start time. Another one: http://build.webkit.org/results/Lion%20Debug%20(WebKit2%20Tests)/r114521%20(6121)/fast/dom/htmlcollection-detectability-crash-log.txt Date/Time: 2012-04-11 00:07:16.193 -0700 Created attachment 137778 [details]
Patch
I think this patch should fix things, although I haven't tested this against a real-world instance. Comment on attachment 137778 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137778&action=review > Tools/Scripts/webkitpy/common/system/crashlogs.py:38 > + def find_newest_log(self, process_name, pid=None, include_errors=False, newer_than=None): I'm not sure if newer_than makes sense as the variable name. I think start_time would be semantically clearer. (In reply to comment #5) > (From update of attachment 137778 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=137778&action=review > > > Tools/Scripts/webkitpy/common/system/crashlogs.py:38 > > + def find_newest_log(self, process_name, pid=None, include_errors=False, newer_than=None): > > I'm not sure if newer_than makes sense as the variable name. I think start_time would be semantically clearer. Interesting, newer_than seems clear to me (show me crash logs newer than X), but start_time not at all (logs don't have a start time) ... why do you think the opposite? Are you thinking that you're looking for processes started after X? The process doesn't have to have started after X, though, just crashed after X. Maybe "created_after" would be better, or "crashed_after", or just "after"? Note that there is a minor correctness issue in that you actually want ctime > X, not mtime > X, but there is no filesystem.ctime() routine. I could add one, but it seemed unnecessary since ctime will presumably equal mtime nearly all of the time ... Comment on attachment 137778 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137778&action=review >>> Tools/Scripts/webkitpy/common/system/crashlogs.py:38 >>> + def find_newest_log(self, process_name, pid=None, include_errors=False, newer_than=None): >> >> I'm not sure if newer_than makes sense as the variable name. I think start_time would be semantically clearer. > > Interesting, newer_than seems clear to me (show me crash logs newer than X), but start_time not at all (logs don't have a start time) ... why do you think the opposite? Are you thinking that you're looking for processes started after X? The process doesn't have to have started after X, though, just crashed after X. > > Maybe "created_after" would be better, or "crashed_after", or just "after"? > > Note that there is a minor correctness issue in that you actually want ctime > X, not mtime > X, but there is no filesystem.ctime() routine. I could add one, but it seemed unnecessary since ctime will presumably equal mtime nearly all of the time ... Ah, I see what you're saying. Okay. Committed r114577: <http://trac.webkit.org/changeset/114577> |