Bug 8417

Summary: make-css-file-arrays.pl hangs when run on Linux
Product: WebKit Reporter: Kevin Ollivier <kevino>
Component: WebCore Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-webkit
Priority: P2    
Version: 420+   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
patch for DerivedSources.make that fixes the hang. darin: review+

Description Kevin Ollivier 2006-04-15 17:58:17 PDT
When WebCore/DerivedSources.make is run on Linux (tested on FC4), WebCore/css/make-css-file-arrays.pl hangs. Patch is attached. (tested on FC4, OS X 10.4.6 Intel and WinXP SP2/Cygwin)
Comment 1 Kevin Ollivier 2006-04-15 17:59:14 PDT
Created attachment 7736 [details]
patch for DerivedSources.make that fixes the hang.
Comment 2 Eric Seidel (no email) 2006-04-15 18:28:12 PDT
Be sure to mark your patch for review.  Also, I think we've generally used #include <assert.h> instead of <cassert>
Comment 3 Darin Adler 2006-04-16 19:26:38 PDT
Comment on attachment 7736 [details]
patch for DerivedSources.make that fixes the hang.

A few comments:

First, this is not a patch for DerivedSources.make!

Second, patches should include change log comments.

Third, include in RenderArena.cpp should be <assert.h>, not <cassert>, to match usage in the rest of the project.

But I think all of these are minor and it's good to just land this, so I will do it as soon as possible.

r=me