Summary: | make-css-file-arrays.pl hangs when run on Linux | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kevin Ollivier <kevino> | ||||
Component: | WebCore Misc. | Assignee: | Darin Adler <darin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-webkit | ||||
Priority: | P2 | ||||||
Version: | 420+ | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Kevin Ollivier
2006-04-15 17:58:17 PDT
Created attachment 7736 [details]
patch for DerivedSources.make that fixes the hang.
Be sure to mark your patch for review. Also, I think we've generally used #include <assert.h> instead of <cassert> Comment on attachment 7736 [details]
patch for DerivedSources.make that fixes the hang.
A few comments:
First, this is not a patch for DerivedSources.make!
Second, patches should include change log comments.
Third, include in RenderArena.cpp should be <assert.h>, not <cassert>, to match usage in the rest of the project.
But I think all of these are minor and it's good to just land this, so I will do it as soon as possible.
r=me
|