Bug 84153 – [EFL] Missing keycode translation for space key

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Sudarsana Nagineni (babu)]

Map 'space' key to Unicode value to fix the issue of simulating space as a click on the button element.

[Sudarsana Nagineni (babu)]

Created attachment 137701 [details]
patch

Add keycode translation for space key

[WebKit Review Bot]

Comment on attachment 137701 [details]
patch

Rejecting attachment 137701 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 FAILED -- saving rejects to file LayoutTests/platform/efl/Skipped.rej
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/platform/efl/EflKeyboardUtilities.cpp
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/DumpRenderTree/efl/EventSender.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12455008

[Sudarsana Nagineni (babu)]

Created attachment 137953 [details]
Patch

rebased

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 137953 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137953&action=review

> Tools/DumpRenderTree/efl/EventSender.cpp:410
> +        return "space";

If you use "Space" it'll be recognized by windowsKeyCodeForEvasKeyName too.

[Sudarsana Nagineni (babu)]

(In reply to comment #4)
> (From update of attachment 137953 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=137953&action=review
> 
> > Tools/DumpRenderTree/efl/EventSender.cpp:410
> > +        return "space";
> 
> If you use "Space" it'll be recognized by windowsKeyCodeForEvasKeyName too.

It should be 'space', and not 'Space'. I checked with EWebLauncher and we get keyname as 'space' from the platform when we press space key.

[Eric Seidel (no email)]

Comment on attachment 137701 [details]
patch

Cleared Antonio Gomes's review+ from obsolete attachment 137701 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Sudarsana Nagineni (babu)]

Created attachment 138015 [details]
Patch

fix WindowsKeyMap for space key.

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 137953 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=137953&action=review
> > 
> > > Tools/DumpRenderTree/efl/EventSender.cpp:410
> > > +        return "space";
> > 
> > If you use "Space" it'll be recognized by windowsKeyCodeForEvasKeyName too.
> 
> It should be 'space', and not 'Space'. I checked with EWebLauncher and we get keyname as 'space' from the platform when we press space key.

You are right. The name is obtained via XKeysymToString, so it's "space".

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 138015 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138015&action=review

Looks fine now, please update a patch with the proper reviewer name in the ChangeLogs so it can be cq+ed.

> Source/WebCore/ChangeLog:13
> +        * platform/efl/EflKeyboardUtilities.cpp:

Please update the ChangeLog and mention what you fixed in createWindowsKeyMap().

[Sudarsana Nagineni (babu)]

Created attachment 138038 [details]
patch

fix changelog.

[WebKit Review Bot]

Comment on attachment 138038 [details]
patch

Clearing flags on attachment: 138038

Committed r114721: <http://trac.webkit.org/changeset/114721>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.