Bug 84143

Summary: [GTK] Allow to use WebInspector in GtkLauncher
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gns, pnormand, webkit.review.bot
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch mrobinson: review+

Description Carlos Garcia Campos 2012-04-17 05:02:56 PDT
It currently crashes when you click on Inspect element context menu item.
Comment 1 Carlos Garcia Campos 2012-04-17 05:07:02 PDT
Created attachment 137517 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-17 05:10:40 PDT
Attachment 137517 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/GNUmakefile.am',..." exit_code: 1
Tools/GtkLauncher/LauncherInspectorWindow.c:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Tools/GtkLauncher/LauncherInspectorWindow.c:50:  launcher_inspector_window_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Tools/GtkLauncher/LauncherInspectorWindow.c:56:  launcher_inspector_window_class_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Tools/GtkLauncher/LauncherInspectorWindow.h:44:  launcher_inspector_window_get_type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Martin Robinson 2012-04-19 16:12:12 PDT
Comment on attachment 137517 [details]
Patch

Nice.
Comment 4 Carlos Garcia Campos 2012-04-19 23:48:13 PDT
Committed r114720: <http://trac.webkit.org/changeset/114720>