Bug 8412

Summary: Restore color profile after a crash
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 36101    
Attachments:
Description Flags
proposed patch darin: review+

Alexey Proskuryakov
Reported 2006-04-15 11:45:25 PDT
The attached patch installs a handler for signals that make the process quit, and restores the color profile. Tested by adding "*(int*)0 = 0;" in the code. It also fixes a bug where the color profile names weren't displayed on a non-English system (CFStringGetCStringPtr should NEVER EVER be used!). I'm also trying to add a way to prevent the Crash Reporter dialog from appearing, but haven't found a good solution yet. This is why I kept the existing handler for manual interruption (SIGINT/SIGHUP/SIGTERM) separate from the crashing case.
Attachments
proposed patch (3.68 KB, patch)
2006-04-15 11:46 PDT, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2006-04-15 11:46:12 PDT
Created attachment 7730 [details] proposed patch
Darin Adler
Comment 2 2006-04-15 18:07:12 PDT
Comment on attachment 7730 [details] proposed patch Looks fine.
Note You need to log in before you can comment on or make changes to this bug.