Bug 84118

Summary:

[chromium] Turn on ENABLE_DATALIST for chromium

Product:

WebKit

Reporter:

Keishi Hattori <keishi>

Component:

Forms

Assignee:

Keishi Hattori <keishi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ec2-cr-linux-03	none
Archive of layout-test-results from ec2-cr-linux-02	none
Patch	none

Keishi Hattori

Reported 2012-04-16 19:19:14 PDT

Turn on ENABLE_DATALIST once the chromium side patch lands.

Attachments
Patch (1019 bytes, patch) 2012-04-17 04:17 PDT, Keishi Hattori	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-03 (6.18 MB, application/zip) 2012-04-17 05:34 PDT, WebKit Review Bot	no flags	Details
Archive of layout-test-results from ec2-cr-linux-02 (6.10 MB, application/zip) 2012-04-17 06:32 PDT, WebKit Review Bot	no flags	Details
Patch (5.50 KB, patch) 2012-04-18 11:07 PDT, Keishi Hattori	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Keishi Hattori

Comment 1 2012-04-17 04:17:25 PDT

Created attachment 137511 [details] Patch

Kent Tamura

Comment 2 2012-04-17 04:23:20 PDT

I recommend touching all of source files affected by ENABLE_DATALIST, like http://trac.webkit.org/changeset/113972 for ENABLE_INPUT_TYPE_DATE. I think some tests not in fast/forms/datalist/ will be affected.

WebKit Review Bot

Comment 3 2012-04-17 05:34:48 PDT

Comment on attachment 137511 [details] Patch Attachment 137511 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12423242 New failing tests: fast/forms/label/labelable-elements.html

WebKit Review Bot

Comment 4 2012-04-17 05:34:53 PDT

Created attachment 137520 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

WebKit Review Bot

Comment 5 2012-04-17 06:32:47 PDT

Comment on attachment 137511 [details] Patch Attachment 137511 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12414900 New failing tests: fast/forms/label/labelable-elements.html

WebKit Review Bot

Comment 6 2012-04-17 06:32:53 PDT

Created attachment 137529 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Keishi Hattori

Comment 7 2012-04-18 11:07:31 PDT

Created attachment 137724 [details] Patch

Kent Tamura

Comment 8 2012-04-18 11:14:56 PDT

Comment on attachment 137724 [details] Patch ok

WebKit Review Bot

Comment 9 2012-04-18 12:32:35 PDT

Comment on attachment 137724 [details] Patch Clearing flags on attachment: 137724 Committed r114545: <http://trac.webkit.org/changeset/114545>

WebKit Review Bot

Comment 10 2012-04-18 12:32:56 PDT

All reviewed patches have been landed. Closing bug.

Kent Tamura

Comment 11 2012-08-17 03:14:42 PDT

We should have excluded Chromium-Android.

Note You need to log in before you can comment on or make changes to this bug.