Bug 84076
| Summary: | wantsAllStreams always returning false, preventing data pass-through for 500 server errors | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Thomas Harning Jr. <harningt> |
| Component: | Plug-ins | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Major | CC: | ahmad.saleem792, andersca, ap, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac (Intel) | ||
| OS: | OS X 10.7 | ||
Thomas Harning Jr.
Similar issue with Firefox that was resolved: https://bugzilla.mozilla.org/show_bug.cgi?id=660989
NPPVpluginWantsAllNetworkStreams is a required item for our plugin in dealing with web service request errors since they return 500 status codes.
Visible in trunk/Source/WebKit/mac/Plugins/Hosted/HostedNetscapePluginStream.mm line 200 is code that always returns false for HostedNetscapePluginStream::wantsAllStreams() and it is marked "TODO".
I couldn't find any other hosted plugin streams browsing through Trac, however I'm guessing this is probably affecting other items. Currently in progress is the massive checkout to see if this is present in other builds.
Reproducible: Always
Steps to Reproduce:
1. Setup an NPAPI plugin that handled NPP_GetValue return returns 'true' for NPPVpluginWantsAllNetworkStreams in the correct manner (or sets it using NPN_SetValue)
2. Ensure OOPP is enabled for the NPAPI plugin in question
3. Perform a web request known to return a non-200 result with NPP_GetURLNotify or NPP_PostURLNotify
Actual Results:
1) No callback to NPP_GetValue for NPPVpluginWantsAllNetworkStreams.
2) A URLNotify callback with failure and no additional data
Expected Results:
1) A callback to NPP_GetValue for NPPVpluginWantsAllNetworkStreams of not set already.
2) A full web request response with headers and data
This bug strongly affects software that we are trying to deploy.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Thomas Harning Jr.
(In reply to comment #0)
> Similar issue with Firefox that was resolved: https://bugzilla.mozilla.org/show_bug.cgi?id=660989
>
> NPPVpluginWantsAllNetworkStreams is a required item for our plugin in dealing with web service request errors since they return 500 status codes.
>
> Visible in
> Steps to Reproduce:
> 1. Setup an NPAPI plugin that handled NPP_GetValue return returns 'true' for NPPVpluginWantsAllNetworkStreams in the correct manner (or sets it using NPN_SetValue)
> 2. Ensure OOPP is enabled for the NPAPI plugin in question
> 3. Perform a web request known to return a non-200 result with NPP_GetURLNotify or NPP_PostURLNotify
Oops, the 'OOP' line was a left-over from the Mozilla-reported bug.
Ahmad Saleem
NPAPI support is removed from Safari 14 onward and it is not supported in Webkit Builds like WebkitGTK as well. I think this can be marked as "RESOLVED WONTFIX". Thanks!
Ryosuke Niwa
Yup, won't fix.