Bug 84036

Summary:

Remove BlobBuilder

Product:

WebKit

Reporter:

Simon Pieters (:zcorpan) <zcorpan>

Component:

WebCore Misc.

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, annevk, ap, ericbidelman, gustavo, jianli, Ms2ger, ojan, rakuco, sam, vestbo, webkit.review.bot, xan.lopez

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

84555

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	andersca: review+

Simon Pieters (:zcorpan)

Reported 2012-04-16 07:53:14 PDT

Please remove BlobBuilder (currently prefixed WebKitBlobBuilder). It has been replaced with the Blob() constructor in the File API spec. Also see https://bugzilla.mozilla.org/show_bug.cgi?id=744907

Attachments
Patch (12.43 KB, patch) 2012-04-29 19:04 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (14.41 KB, patch) 2012-04-30 11:58 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (14.42 KB, patch) 2012-04-30 13:24 PDT, Sam Weinig	andersca: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2012-04-16 22:01:26 PDT

<rdar://problem/11261686>

Sam Weinig

Comment 2 2012-04-22 16:29:27 PDT

Given that Chrome has shipped WebKitBlobBuilder for while, we will have to tred carefully here. As a first step, we should probably just implement the Blob constructor.

Sam Weinig

Comment 3 2012-04-22 16:57:27 PDT

I filed https://bugs.webkit.org/show_bug.cgi?id=84555 to track adding the Blob constructor.

Sam Weinig

Comment 4 2012-04-29 19:04:28 PDT

Created attachment 139412 [details] Patch

Sam Weinig

Comment 5 2012-04-29 19:06:35 PDT

This patch adds a flag, ENABLE_LEGACY_WEBKIT_BLOB_BUILDER, to control exposing the WebKitBlobBuilder. (It doesn't control whether the C++ class is compiled, as that is used internally). It also disables WebKitBlobBuilder on the Mac port, since we have never shipped it, it doesn't make sense to keep it enabled.

Gustavo Noronha (kov)

Comment 6 2012-04-29 19:11:15 PDT

Comment on attachment 139412 [details] Patch Attachment 139412 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12582102

Sam Weinig

Comment 7 2012-04-30 11:58:53 PDT

Created attachment 139499 [details] Patch

Ms2ger (he/him; ⌚ UTC+1/+2)

Comment 8 2012-04-30 12:34:48 PDT

{ option => "legacy-notifications", desc => "Toggle Legacy WebKitBlobBuilder Support", Is that first string correct?

Anders Carlsson

Comment 9 2012-04-30 13:21:58 PDT

Comment on attachment 139499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139499&action=review > Tools/Scripts/build-webkit:271 > + { option => "legacy-notifications", desc => "Toggle Legacy WebKitBlobBuilder Support", > + define => "ENABLE_LEGACY_NOTIFICATIONS", default => (isGtk() || isChromium() || isBlackBerry()), value => \$legacyWebKitBlobBuilderSupport }, I don't think this is the right option name...

Sam Weinig

Comment 10 2012-04-30 13:24:16 PDT

Created attachment 139507 [details] Patch

Sam Weinig

Comment 11 2012-04-30 14:10:49 PDT

Committed r115666: <http://trac.webkit.org/changeset/115666>

Note You need to log in before you can comment on or make changes to this bug.