Bug 84022

Summary:

[CG] ImageBuffer: check getPremultipliedImageData() error return

Product:

WebKit

Reporter:

noel gordon <noel.gordon>

Component:

New Bugs

Assignee:

noel gordon <noel.gordon>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, mitz, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description noel gordon 2012-04-16 05:05:02 PDT

[CG] ImageBufffer: check getPremultipliedImageData() error return

Comment 1 noel gordon 2012-04-16 05:06:57 PDT

Created attachment 137321 [details]
Patch

Comment 2 noel gordon 2012-04-16 05:18:15 PDT

Reopening to attach new patch.

Comment 3 noel gordon 2012-04-16 05:18:20 PDT

Created attachment 137327 [details]
Patch

Comment 4 Eric Seidel (no email) 2012-04-16 14:07:58 PDT

Comment on attachment 137327 [details]
Patch

So does this mean we now pass more of that test?  I'm surprised not to see any expectation changes?

Comment 5 noel gordon 2012-04-18 00:55:06 PDT

No change in behavior test-wise: we still pass canvas/philip/tests/toDataURL.jpeg.alpha.html, which covers this area of the code.

Comment 6 WebKit Review Bot 2012-04-18 01:06:02 PDT

Comment on attachment 137327 [details]
Patch

Clearing flags on attachment: 137327

Committed r114491: <http://trac.webkit.org/changeset/114491>

Comment 7 WebKit Review Bot 2012-04-18 01:06:07 PDT

All reviewed patches have been landed.  Closing bug.

Comment 8 noel gordon 2012-04-18 22:13:55 PDT

Oh and did we noticed that loop stuffing 255 into the alpha channel.  The encoder is so fast that iterating over pixels to reformat them becomes a significant factor in overall encoding time.  Surely the CG jpeg encoder can be told to ignore the alpha channel.  Investigating ...

Comment 9 noel gordon 2012-04-18 23:22:08 PDT

Filed bug 84319.