Summary: | [GTK] atk/textChangedNotifications API test fails | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | jiapu.mail, mario, morrita, mrobinson | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Philippe Normand
2012-04-16 00:21:49 PDT
Created attachment 137346 [details]
Patch proposal
It is segfaulting in WebCore::Editor, at Source/WebCore/editing/Editor.cpp:920. See the snippet:
bool Editor::insertTextWithoutSendingTextEvent(const String& text, bool selectInsertedText, TextEvent* triggeringEvent)
{
[...]
if (selection.isContentEditable()) {
if (Node* selectionStart = selection.start().deprecatedNode()) {
RefPtr<Document> document = selectionStart->document();
// Insert the text
if (triggeringEvent->isDictation()) <--- SEGV here, triggeringEvent might be NULL (see check in line below, in the else branch)
DictationCommand::insertText(document.get(), text, triggeringEvent->dictationAlternatives(), selection);
else {
TypingCommand::Options options = 0;
if (selectInsertedText)
options |= TypingCommand::SelectInsertedText;
if (autocorrectionWasApplied)
options |= TypingCommand::RetainAutocorrectionIndicator;
TypingCommand::insertText(document.get(), text, selection, options, triggeringEvent && triggeringEvent->isComposition() ? TypingCommand::TextCompositionConfirm : TypingCommand::TextCompositionNone);
}
[...]
}
So, the attached patch would fix the issue.
Is Dictation a new feature? I'm surprised it isn't behind a compile-time flag. (In reply to comment #2) > Is Dictation a new feature? I'm surprised it isn't behind a compile-time flag. Currently this is used only by OS X. I can certainly put it behind compile time flag, if that's desirable. It seems http://trac.webkit.org/changeset/114311 has already fixed this. We just need to unskip the test now. Committed r114490: <http://trac.webkit.org/changeset/114490> Comment on attachment 137346 [details] Patch proposal Cleared review? from attachment 137346 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). |