Bug 83992

Summary:

DFG should have out-of-line slow paths

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

83987

Bug Blocks:

Attachments:

Description	Flags
it sort of compiles	none
defoobared the changelog	none
it works but not on 32-bit	webkit-ews: commit-queue-
I think it works	buildbot: commit-queue-
fixing style/build errors	none
the patch	oliver: review+

Filip Pizlo

Reported 2012-04-14 20:07:57 PDT

This is a work in progress.

Attachments
it sort of compiles (117.56 KB, patch) 2012-04-14 20:13 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
defoobared the changelog (95.69 KB, patch) 2012-04-14 20:16 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
it works but not on 32-bit (100.55 KB, patch) 2012-04-15 01:37 PDT, Filip Pizlo	webkit-ews: commit-queue-	Details Formatted Diff Diff
I think it works (137.11 KB, patch) 2012-04-15 14:50 PDT, Filip Pizlo	buildbot: commit-queue-	Details Formatted Diff Diff
fixing style/build errors (137.15 KB, patch) 2012-04-15 18:11 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (138.71 KB, patch) 2012-04-16 16:35 PDT, Filip Pizlo	oliver: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2012-04-14 20:13:43 PDT

Created attachment 137227 [details] it sort of compiles Work in progress

Filip Pizlo

Comment 2 2012-04-14 20:16:36 PDT

Created attachment 137228 [details] defoobared the changelog had to convince emacs to not make random unnecessary and incorrect changes to the charset of the ChangeLog

Filip Pizlo

Comment 3 2012-04-15 01:37:04 PDT

Created attachment 137231 [details] it works but not on 32-bit sub 1% speed-ups. yay.

WebKit Review Bot

Comment 4 2012-04-15 01:39:05 PDT

Attachment 137231 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGSlowPathGenerator.h:64: The parameter name "jit" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 5 2012-04-15 01:41:32 PDT

Comment on attachment 137231 [details] it works but not on 32-bit Attachment 137231 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12405650

Early Warning System Bot

Comment 6 2012-04-15 01:43:03 PDT

Comment on attachment 137231 [details] it works but not on 32-bit Attachment 137231 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12408543

Build Bot

Comment 7 2012-04-15 01:51:24 PDT

Comment on attachment 137231 [details] it works but not on 32-bit Attachment 137231 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12406581

Filip Pizlo

Comment 8 2012-04-15 14:50:04 PDT

Created attachment 137250 [details] I think it works It appears to work, but I still have a bunch more tests to run to be sure. I will mark r? when https://bugs.webkit.org/show_bug.cgi?id=83987 is resolved and when I finish doing the due diligence.

WebKit Review Bot

Comment 9 2012-04-15 14:53:36 PDT

Attachment 137250 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGSlowPathGenerator.h:64: The parameter name "jit" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 10 2012-04-15 15:25:08 PDT

Comment on attachment 137250 [details] I think it works Attachment 137250 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12412034

Filip Pizlo

Comment 11 2012-04-15 18:11:31 PDT

Created attachment 137259 [details] fixing style/build errors

Filip Pizlo

Comment 12 2012-04-16 16:35:46 PDT

Created attachment 137428 [details] the patch

Oliver Hunt

Comment 13 2012-04-16 16:58:23 PDT

Comment on attachment 137428 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=137428&action=review > Source/JavaScriptCore/dfg/DFGSilentRegisterSavePlan.h:79 > + SilentRegisterSavePlan(SilentSpillAction spillAction, die emacs die

Filip Pizlo

Comment 14 2012-04-16 17:46:17 PDT

(In reply to comment #13) > (From update of attachment 137428 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=137428&action=review > > > Source/JavaScriptCore/dfg/DFGSilentRegisterSavePlan.h:79 > > + SilentRegisterSavePlan(SilentSpillAction spillAction, > > die emacs die the emacs the?

Filip Pizlo

Comment 15 2012-04-17 17:34:34 PDT

Landed in http://trac.webkit.org/changeset/114472

Filip Pizlo

Comment 16 2012-04-18 13:37:54 PDT

Build fix in http://trac.webkit.org/changeset/114553

Filip Pizlo

Comment 17 2012-05-18 13:43:31 PDT

Marged (with build fix) in http://trac.webkit.org/changeset/117620

Note You need to log in before you can comment on or make changes to this bug.