| Summary: | DFG should have out-of-line slow paths | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||||||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | webkit.review.bot | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | All | ||||||||||||||||
| OS: | All | ||||||||||||||||
| Bug Depends on: | 83987 | ||||||||||||||||
| Bug Blocks: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Filip Pizlo
2012-04-14 20:07:57 PDT
Created attachment 137227 [details]
it sort of compiles
Work in progress
Created attachment 137228 [details]
defoobared the changelog
had to convince emacs to not make random unnecessary and incorrect changes to the charset of the ChangeLog
Created attachment 137231 [details]
it works but not on 32-bit
sub 1% speed-ups. yay.
Attachment 137231 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/dfg/DFGSlowPathGenerator.h:64: The parameter name "jit" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 137231 [details] it works but not on 32-bit Attachment 137231 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12405650 Comment on attachment 137231 [details] it works but not on 32-bit Attachment 137231 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12408543 Comment on attachment 137231 [details] it works but not on 32-bit Attachment 137231 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12406581 Created attachment 137250 [details] I think it works It appears to work, but I still have a bunch more tests to run to be sure. I will mark r? when https://bugs.webkit.org/show_bug.cgi?id=83987 is resolved and when I finish doing the due diligence. Attachment 137250 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/dfg/DFGSlowPathGenerator.h:64: The parameter name "jit" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 137250 [details] I think it works Attachment 137250 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12412034 Created attachment 137259 [details]
fixing style/build errors
Created attachment 137428 [details]
the patch
Comment on attachment 137428 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=137428&action=review > Source/JavaScriptCore/dfg/DFGSilentRegisterSavePlan.h:79 > + SilentRegisterSavePlan(SilentSpillAction spillAction, die emacs die (In reply to comment #13) > (From update of attachment 137428 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=137428&action=review > > > Source/JavaScriptCore/dfg/DFGSilentRegisterSavePlan.h:79 > > + SilentRegisterSavePlan(SilentSpillAction spillAction, > > die emacs die the emacs the? Landed in http://trac.webkit.org/changeset/114472 Build fix in http://trac.webkit.org/changeset/114553 Marged (with build fix) in http://trac.webkit.org/changeset/117620 |