Bug 83988

Summary:

Remove contextStyleSheet argument from CSSValuePool::createFontFaceValue()

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kling, macpherson, menard, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Pretty much a patch	none

Description Antti Koivisto 2012-04-14 15:33:39 PDT

CSSValuePool::createFontFaceValue() takes context stylesheet as argument. This was ok when the pool was per-document but with global pool it can lead to font faces with relative URLs getting wrong base URL.

Comment 1 Antti Koivisto 2012-04-14 15:34:38 PDT

This was added in http://trac.webkit.org/changeset/108451

Comment 2 Andreas Kling 2012-04-16 15:44:54 PDT

There's no real bug here (yet) since CSSValuePool::createFontFaceValue() never ends up parsing a URL value. However we should still remove the contextStyleSheet argument as we can get away without it.

Comment 3 Antti Koivisto 2012-04-16 15:47:46 PDT

Retitled

Comment 4 Andreas Kling 2012-04-16 15:59:25 PDT

(In reply to comment #3)
> Retitled

I was trying to save you some face bro. Now everyone knows your assessment was partially incorrect :(

Comment 5 Andreas Kling 2012-04-16 16:01:26 PDT

Created attachment 137422 [details]
Pretty much a patch

Comment 6 WebKit Review Bot 2012-04-16 17:28:27 PDT

Comment on attachment 137422 [details]
Pretty much a patch

Clearing flags on attachment: 137422

Committed r114325: <http://trac.webkit.org/changeset/114325>

Comment 7 WebKit Review Bot 2012-04-16 17:28:32 PDT

All reviewed patches have been landed.  Closing bug.