Bug 83988

Summary: Remove contextStyleSheet argument from CSSValuePool::createFontFaceValue()
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Pretty much a patch none

Antti Koivisto
Reported 2012-04-14 15:33:39 PDT
CSSValuePool::createFontFaceValue() takes context stylesheet as argument. This was ok when the pool was per-document but with global pool it can lead to font faces with relative URLs getting wrong base URL.
Attachments
Pretty much a patch (5.44 KB, patch)
2012-04-16 16:01 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2012-04-14 15:34:38 PDT
This was added in http://trac.webkit.org/changeset/108451
Andreas Kling
Comment 2 2012-04-16 15:44:54 PDT
There's no real bug here (yet) since CSSValuePool::createFontFaceValue() never ends up parsing a URL value. However we should still remove the contextStyleSheet argument as we can get away without it.
Antti Koivisto
Comment 3 2012-04-16 15:47:46 PDT
Retitled
Andreas Kling
Comment 4 2012-04-16 15:59:25 PDT
(In reply to comment #3) > Retitled I was trying to save you some face bro. Now everyone knows your assessment was partially incorrect :(
Andreas Kling
Comment 5 2012-04-16 16:01:26 PDT
Created attachment 137422 [details] Pretty much a patch
WebKit Review Bot
Comment 6 2012-04-16 17:28:27 PDT
Comment on attachment 137422 [details] Pretty much a patch Clearing flags on attachment: 137422 Committed r114325: <http://trac.webkit.org/changeset/114325>
WebKit Review Bot
Comment 7 2012-04-16 17:28:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.