Summary: | [WK2] Use ShareableSurface instead of ShareableBitmap in DrawingAreaImpl | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Igor Trindade Oliveira <igor.oliveira> | ||||||||||||||||
Component: | WebKit2 | Assignee: | Igor Trindade Oliveira <igor.oliveira> | ||||||||||||||||
Status: | NEW --- | ||||||||||||||||||
Severity: | Normal | CC: | alex, andersca, dglazkov, hausmann, hsong, kenneth, menard, mrobinson, noam, rakuco, webkit.review.bot, zoltan | ||||||||||||||||
Priority: | P2 | ||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||
Hardware: | All | ||||||||||||||||||
OS: | All | ||||||||||||||||||
Attachments: |
|
Description
Igor Trindade Oliveira
2012-04-13 16:04:39 PDT
Created attachment 137175 [details]
Patch
WIP patch.
Created attachment 137354 [details]
Patch
Proposed patch.
Attachment 137354 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebKit2/Shared/ShareableSurface.h:67: The parameter name "hints" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 137354 [details] Patch Attachment 137354 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12416147 Created attachment 137359 [details]
Patch
Fix windows build.
Attachment 137359 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebKit2/Shared/ShareableSurface.h:67: The parameter name "hints" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 16 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 137359 [details] Patch Attachment 137359 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12412438 Comment on attachment 137359 [details] Patch Attachment 137359 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12414447 New failing tests: fast/canvas/webgl/shader-precision-format.html Created attachment 137386 [details]
Archive of layout-test-results from ec2-cr-linux-01
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 137459 [details]
Patch
Trying again.
Comment on attachment 137459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137459&action=review > Source/WebKit2/Shared/ShareableSurface.h:41 > + SupportsGraphicsSurface = 0x01, > + None = 0x0 I'd rather if we put None first, and call it NoHints Comment on attachment 137459 [details] Patch Attachment 137459 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12414631 Created attachment 137471 [details]
Patch
Use NoHints instead of None.
Comment on attachment 137471 [details] Patch Attachment 137471 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12416438 Created attachment 137474 [details]
Patch
it is becoming boring, trying again.
(In reply to comment #0) > GTK and EFL port have plans to use OpenGL instead of Image backend, as initial step in WebKit2 we should use ShareableSurface instead of ShareableBitmap, so we can use OpenGL surfaces. You say initial step, but are you actually going to end up with that design? I mean, if you go through with this you're also going to have to change the backing stores to be surfaces, and you'll probably want to combine multiple updates into the same surface. And then you'll end up half-way re-implementing what exists already for the WK2 AC implementation. So wouldn't it be simpler to leave the drawing area with its working approach of using shared memory and software rendering (and update incorporation) and instead focus on the WK2 AC implementation? Because I suspect in the end you're going to want to use that and remain in permanent state of AC. (In reply to comment #16) > (In reply to comment #0) > > GTK and EFL port have plans to use OpenGL instead of Image backend, as initial step in WebKit2 we should use ShareableSurface instead of ShareableBitmap, so we can use OpenGL surfaces. > > You say initial step, but are you actually going to end up with that design? > > I mean, if you go through with this you're also going to have to change the backing stores to be surfaces, and you'll probably want to combine multiple updates into the same surface. And then you'll end up half-way re-implementing what exists already for the WK2 AC implementation. > > So wouldn't it be simpler to leave the drawing area with its working approach of using shared memory and software rendering (and update incorporation) and instead focus on the WK2 AC implementation? Because I suspect in the end you're going to want to use that and remain in permanent state of AC. I totally agree with that. That would be the right approach. Comment on attachment 137474 [details]
Patch
I'm saying r- based on the lack of clarity about where this is going and why it is better than putting an effort into getting WK2 AC working for the ports in question.
|