Bug 83935

Summary: [Chromium] Fix tests being flaky when multiple draws occur in between commits
Product: WebKit Reporter: Daniel Sievers <sievers>
Component: New BugsAssignee: Daniel Sievers <sievers>
Status: RESOLVED FIXED    
Severity: Normal CC: danakj, enne, eric, jamesr, nduca, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Daniel Sievers
Reported 2012-04-13 12:59:50 PDT
[Chromium] Fix tests being flaky when multiple draws occur in between commits
Attachments
Patch (7.08 KB, patch)
2012-04-13 13:05 PDT, Daniel Sievers 		no flags
DetailsFormatted DiffDiff
Patch (7.33 KB, patch)
2012-04-13 14:27 PDT, Daniel Sievers 		no flags
DetailsFormatted DiffDiff
Patch (5.70 KB, patch)
2012-05-22 11:28 PDT, Daniel Sievers 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Daniel Sievers
Comment 1 2012-04-13 13:05:14 PDT
Created attachment 137131 [details] Patch
Daniel Sievers
Comment 2 2012-04-13 13:08:09 PDT
The decrement by one is from drawLayersOnCCThread() being called after drawLayers() where the old code using frameNumber() had the increment happen before in drawLayers(), while the sourceFrameNumber() increment takes place in finishCommitOnImplThread().
Adrienne Walker
Comment 3 2012-04-13 13:35:02 PDT
Comment on attachment 137131 [details] Patch R=me. Nice catch.
Daniel Sievers
Comment 4 2012-04-13 14:27:08 PDT
Created attachment 137150 [details] Patch
Eric Seidel (no email)
Comment 5 2012-05-21 14:28:41 PDT
Ping? I think James is probably your man here.
James Robinson
Comment 6 2012-05-21 14:33:16 PDT
We had a review already (from enne@) on patch set one - I guess it got lost in a rebasing patch?
James Robinson
Comment 7 2012-05-21 14:33:27 PDT
Comment on attachment 137150 [details] Patch Still looks good.
Daniel Sievers
Comment 8 2012-05-22 11:28:10 PDT
Created attachment 143332 [details] Patch
Adrienne Walker
Comment 9 2012-05-22 12:18:56 PDT
Comment on attachment 143332 [details] Patch Still looks good X 3. Daniel: If you get an R+ and just need to rebase a patch, you can change the "Reviewed by NOBODY (OOPS!)." line to "Reviewed by $person." and then just ask for CQ? instead of R? CQ?.
WebKit Review Bot
Comment 10 2012-05-22 13:16:35 PDT
Comment on attachment 143332 [details] Patch Clearing flags on attachment: 143332 Committed r118034: <http://trac.webkit.org/changeset/118034>
WebKit Review Bot
Comment 11 2012-05-22 13:16:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.