Bug 83883

Summary:

Web Inspector: exception in heap profiler when expanding a class in summary view

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

Web Inspector (Deprecated)

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alph, apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	pfeldman: review+, webkit.review.bot: commit-queue-

Yury Semikhatsky

Reported 2012-04-13 05:36:33 PDT

at quickSortFirstK (chrome-devtools://devtools/PartialQuickSort.js:40:35) at Array.<anonymous> (chrome-devtools://devtools/PartialQuickSort.js:49:9) at Object.sort (chrome-devtools://devtools/HeapSnapshot.js:1837:30) at Object.serializeNextItems (chrome-devtools://devtools/HeapSnapshot.js:1665:18) at Object.dispatchMessage (chrome-devtools://devtools/HeapSnapshotWorkerDispatcher.js:82:63)

Attachments
Patch (59.59 KB, patch) 2012-04-13 06:25 PDT, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Patch (68.65 KB, patch) 2012-04-13 06:45 PDT, Yury Semikhatsky	pfeldman: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2012-04-13 05:36:54 PDT

Looks like regression after http://trac.webkit.org/changeset/113994

Yury Semikhatsky

Comment 2 2012-04-13 06:25:32 PDT

Created attachment 137075 [details] Patch

Pavel Feldman

Comment 3 2012-04-13 06:30:09 PDT

Comment on attachment 137075 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137075&action=review > Source/WebCore/inspector/front-end/DOMUtils.js:36 > +Node.prototype.rangeOfWord = function(offset, stopCharacters, stayWithinNode, direction) I would call this file DOMExtension.js and would move highlight-related methods into the WebInspector.UIUtils, into the WebInspector namespace.

Yury Semikhatsky

Comment 4 2012-04-13 06:45:38 PDT

Created attachment 137079 [details] Patch

WebKit Review Bot

Comment 5 2012-04-13 06:49:09 PDT

Comment on attachment 137079 [details] Patch Attachment 137079 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12391950

Yury Semikhatsky

Comment 6 2012-04-13 06:51:04 PDT

Committed r114126: <http://trac.webkit.org/changeset/114126>

Note You need to log in before you can comment on or make changes to this bug.