| Summary: | JSDocument::setLocation does too much bare-handed lifting | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Adam Barth
2012-04-12 18:50:07 PDT
Created attachment 137022 [details]
Patch
Comment on attachment 137022 [details] Patch Clearing flags on attachment: 137022 Committed r114098: <http://trac.webkit.org/changeset/114098> All reviewed patches have been landed. Closing bug. Comment on attachment 137022 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137022&action=review > Source/WebCore/bindings/js/JSDocumentCustom.cpp:74 > + UString locationString = value.toString(exec)->value(exec); > + if (exec->hadException()) > + return; Is there no exception possible in toString? If there is, I think we’d need two separate return statements. Comment on attachment 137022 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137022&action=review >> Source/WebCore/bindings/js/JSDocumentCustom.cpp:74 >> + return; > > Is there no exception possible in toString? If there is, I think we’d need two separate return statements. Or maybe toString can have an exception, but value can't. (In reply to comment #5) > (From update of attachment 137022 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=137022&action=review > > >> Source/WebCore/bindings/js/JSDocumentCustom.cpp:74 > >> + return; > > > > Is there no exception possible in toString? If there is, I think we’d need two separate return statements. > > Or maybe toString can have an exception, but value can't. I believe that's the case, but I'll verify by reading the code. |