Bug 83828

Summary: There are no shared worker filesystem tests
Product: WebKit Reporter: Eric U. <ericu>
Component: DOMAssignee: Eric U. <ericu>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, kinuko, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch levin: review+

Eric U.
Reported 2012-04-12 15:53:02 PDT
We should have at least one that verifies basic functionality. There shouldn't be any difference in implementation between shared and dedicated workers, so one's probably plenty.
Attachments
Patch (8.39 KB, patch)
2012-04-12 16:23 PDT, Eric U. 		no flags
DetailsFormatted DiffDiff
Patch (8.08 KB, patch)
2012-04-23 11:10 PDT, Eric U. 		levin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric U.
Comment 1 2012-04-12 16:23:05 PDT
Created attachment 136993 [details] Patch
Kinuko Yasuda
Comment 2 2012-04-16 20:14:10 PDT
Comment on attachment 136993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136993&action=review > LayoutTests/fast/filesystem/workers/file-writer-events-shared.html:14 > + //worker.port.postMessage("IMPORT:../../filesystem/simple-persistent.html"); Do we need these commented out lines? > LayoutTests/fast/js/resources/js-test-pre.js:509 > +var workerPort; Probably we should put this var together with other global var declarations at the beginning of this file.
Eric U.
Comment 3 2012-04-23 11:10:06 PDT
(In reply to comment #2) > (From update of attachment 136993 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=136993&action=review > > > LayoutTests/fast/filesystem/workers/file-writer-events-shared.html:14 > > + //worker.port.postMessage("IMPORT:../../filesystem/simple-persistent.html"); > > Do we need these commented out lines? Nope--accidentally left them in there while experimenting. Removed. > > LayoutTests/fast/js/resources/js-test-pre.js:509 > > +var workerPort; > > Probably we should put this var together with other global var declarations at the beginning of this file. Actually, it doesn't need to be global at all, due to the closures. Changed to local.
Eric U.
Comment 4 2012-04-23 11:10:44 PDT
Created attachment 138388 [details] Patch
Eric U.
Comment 5 2012-05-21 15:01:22 PDT
Ping? This is quite small, and fixes a piece of the test harness that misrepresents itself as supporting shared workers.
Eric Seidel (no email)
Comment 6 2012-05-21 15:20:55 PDT
I suspect Levin could review this tiny patch, even though he's a busy-busy man these days.
David Levin
Comment 7 2012-05-21 15:41:51 PDT
Comment on attachment 138388 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138388&action=review > LayoutTests/fast/filesystem/workers/file-writer-events-shared.html:1 > +<!DOCTYPE HTML> Personally I would prefer -shared-work instead of just -shared (because I can't figure out what -shared means immediately when I see it like this.). But I'm not so adamant that I think you must do this before checking in. Consider this a "If it isn't too much trouble, it sure would be nice if..."
Eric U.
Comment 8 2012-05-23 14:25:48 PDT
Comment on attachment 138388 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138388&action=review >> LayoutTests/fast/filesystem/workers/file-writer-events-shared.html:1 >> +<!DOCTYPE HTML> > > Personally I would prefer -shared-work instead of just -shared (because I can't figure out what -shared means immediately when I see it like this.). > > But I'm not so adamant that I think you must do this before checking in. > > Consider this a "If it isn't too much trouble, it sure would be nice if..." Switched to -shared-worker.
Eric U.
Comment 9 2012-05-23 14:44:59 PDT
Committed r118246: <http://trac.webkit.org/changeset/118246>
Note You need to log in before you can comment on or make changes to this bug.