Bug 83812
| Summary: | skia: use clipstack instead of (deprecated) getTotalClip | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mike Reed <reed> |
| Component: | Forms | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | bsalomon, caryclark, schenney |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Mike Reed
The current use of getTotalClip in BitLockerSkia.cpp is to transfer the skia clip into a CGContext. However, skia (and webkit) now use antialiased clips at times, and these are not represent in the SkRegion that is returned by getTotalClip.
The SkClipStack stored by the canvas contains the actual paths used to construct the clip, and with it we should be able to make CGContext calls to reproduce the clip, including its soft-edges.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Mike Reed
Skia rev. 3670 just landed ClipVisitor proxy, which will allow us to replay the clips into CGContext...