Summary: | [chromium] DomStorage house cleaning | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Nordman <michaeln> | ||||||||||
Component: | WebKit API | Assignee: | Michael Nordman <michaeln> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Michael Nordman
2012-04-12 12:56:42 PDT
Created attachment 136976 [details]
house cleaning
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 136976 [details] house cleaning Attachment 136976 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12395471 New failing tests: svg/transforms/text-with-mask-with-svg-transform.svg Created attachment 136984 [details]
Archive of layout-test-results from ec2-cr-linux-03
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Test failure looks unrelated, from http://queues.webkit.org/patch/136976 "Unable to pass tests without patch (tree is red?) [results] 23 minutes ago" > "Unable to pass tests without patch (tree is red?) [results] 23 minutes ago"
It always says that. The WebKit tree is always red. :)
Comment on attachment 136976 [details] house cleaning View in context: https://bugs.webkit.org/attachment.cgi?id=136976&action=review > Source/WebKit/chromium/src/StorageEventDispatcherImpl.cpp:52 > +// FIXME(michaeln): add a sourceStorageArea parameter to this FIXME(michaeln) => FIXME (WebKit doesn't attribute FIXMEs.) thnx! (In reply to comment #8) > thnx! No, thank you sir. Created attachment 137021 [details]
house cleaning patch for landing
Comment on attachment 137021 [details] house cleaning patch for landing Rejecting attachment 137021 [details] from commit-queue. New failing tests: svg/text/font-size-below-point-five.svg Full output: http://queues.webkit.org/results/12392788 Created attachment 137047 [details]
Archive of layout-test-results from ec2-cq-02
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
bah... i'll land manually Committed r114160: <http://trac.webkit.org/changeset/114160> |