Bug 83807

Summary: [chromium] DomStorage house cleaning
Product: WebKit Reporter: Michael Nordman <michaeln>
Component: WebKit APIAssignee: Michael Nordman <michaeln>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
house cleaning
abarth: review+, michaeln: commit-queue-
Archive of layout-test-results from ec2-cr-linux-03
none
house cleaning patch for landing
webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cq-02 none

Michael Nordman
Reported 2012-04-12 12:56:42 PDT
Now that the chromium port is using a different dom_storage backend library in it's main browser process, there are many files that should no longer be included in our build, and a few files than should be deleted outright, and the webkit api should be modified to reflect the new (and smaller) contract between the embedder and webkit/webcore.
Attachments
house cleaning (28.81 KB, patch)
2012-04-12 14:39 PDT, Michael Nordman 		abarth: review+
michaeln: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-03 (6.65 MB, application/zip)
2012-04-12 15:33 PDT, WebKit Review Bot 		no flags
Details
house cleaning patch for landing (28.77 KB, patch)
2012-04-12 18:49 PDT, Michael Nordman 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cq-02 (6.24 MB, application/zip)
2012-04-13 00:05 PDT, WebKit Review Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Nordman
Comment 1 2012-04-12 14:39:12 PDT
Created attachment 136976 [details] house cleaning
WebKit Review Bot
Comment 2 2012-04-12 14:41:06 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 3 2012-04-12 15:33:17 PDT
Comment on attachment 136976 [details] house cleaning Attachment 136976 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12395471 New failing tests: svg/transforms/text-with-mask-with-svg-transform.svg
WebKit Review Bot
Comment 4 2012-04-12 15:33:23 PDT
Created attachment 136984 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Michael Nordman
Comment 5 2012-04-12 15:58:33 PDT
Test failure looks unrelated, from http://queues.webkit.org/patch/136976 "Unable to pass tests without patch (tree is red?) [results] 23 minutes ago"
Adam Barth
Comment 6 2012-04-12 16:58:50 PDT
> "Unable to pass tests without patch (tree is red?) [results] 23 minutes ago" It always says that. The WebKit tree is always red. :)
Adam Barth
Comment 7 2012-04-12 17:00:26 PDT
Comment on attachment 136976 [details] house cleaning View in context: https://bugs.webkit.org/attachment.cgi?id=136976&action=review > Source/WebKit/chromium/src/StorageEventDispatcherImpl.cpp:52 > +// FIXME(michaeln): add a sourceStorageArea parameter to this FIXME(michaeln) => FIXME (WebKit doesn't attribute FIXMEs.)
Michael Nordman
Comment 8 2012-04-12 17:01:15 PDT
thnx!
Adam Barth
Comment 9 2012-04-12 17:03:59 PDT
(In reply to comment #8) > thnx! No, thank you sir.
Michael Nordman
Comment 10 2012-04-12 18:49:07 PDT
Created attachment 137021 [details] house cleaning patch for landing
WebKit Review Bot
Comment 11 2012-04-13 00:05:37 PDT
Comment on attachment 137021 [details] house cleaning patch for landing Rejecting attachment 137021 [details] from commit-queue. New failing tests: svg/text/font-size-below-point-five.svg Full output: http://queues.webkit.org/results/12392788
WebKit Review Bot
Comment 12 2012-04-13 00:05:43 PDT
Created attachment 137047 [details] Archive of layout-test-results from ec2-cq-02 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: ec2-cq-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Michael Nordman
Comment 13 2012-04-13 11:54:14 PDT
bah... i'll land manually
Michael Nordman
Comment 14 2012-04-13 12:34:53 PDT
Committed r114160: <http://trac.webkit.org/changeset/114160>
Note You need to log in before you can comment on or make changes to this bug.