Bug 83759

Summary:

AudioContext createChannelMerger() method should have optional argument for number of inputs.

Product:

WebKit

Reporter:

Raymond <rgbbones>

Component:

Web Audio

Assignee:

Raymond <rgbbones>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, crogers, eric.carlson, feature-media-reviews, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Raymond

Reported 2012-04-12 01:28:29 PDT

AudioContext createChannelMerger() method should have optional argument for number of inputs.

Attachments
Patch (10.35 KB, patch) 2012-04-12 01:29 PDT, Raymond	no flags	Details Formatted Diff Diff
Patch (10.38 KB, patch) 2012-04-12 18:14 PDT, Raymond	no flags	Details Formatted Diff Diff
Patch (10.41 KB, patch) 2012-04-12 18:57 PDT, Raymond	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Raymond

Comment 1 2012-04-12 01:29:38 PDT

Created attachment 136848 [details] Patch

Raymond

Comment 2 2012-04-12 01:32:21 PDT

Hi Chris Please take a review on this. Layout test case added too.

Chris Rogers

Comment 3 2012-04-12 12:13:49 PDT

Comment on attachment 136848 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136848&action=review Looks good overall - a couple of minor comments: > Source/WebCore/Modules/webaudio/AudioChannelMerger.cpp:52 > // Create a fixed number of inputs (able to handle the maximum number of channels we deal with). I might change the comment slightly: "Create a fixed number" -> "Create the requested number" > LayoutTests/webaudio/audiochannelmerger-basic-expected.txt:7 > +PASS ChannelMerger created successfully with numerOfInputs = 32. typo: "numerOfInputs" ->"numberOfInputs"

Raymond

Comment 4 2012-04-12 18:14:07 PDT

Created attachment 137008 [details] Patch

Raymond

Comment 5 2012-04-12 18:14:52 PDT

(In reply to comment #3) Hi Chris Thanks for the review. Patch updated.

Chris Rogers

Comment 6 2012-04-12 18:22:00 PDT

Comment on attachment 137008 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137008&action=review > LayoutTests/webaudio/audiochannelmerger-basic-expected.txt:6 > +PASS Exception been thrown for numberOfInputs >= 32. "been" -> "was" > LayoutTests/webaudio/audiochannelmerger-basic-expected.txt:8 > +PASS ChannelMerger created successfully with empty parameter. ChannelMerger -> AudioChannelMerger

Raymond

Comment 7 2012-04-12 18:57:29 PDT

Created attachment 137025 [details] Patch

Raymond

Comment 8 2012-04-12 18:58:29 PDT

(In reply to comment #6) > (From update of attachment 137008 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=137008&action=review > > > LayoutTests/webaudio/audiochannelmerger-basic-expected.txt:6 > > +PASS Exception been thrown for numberOfInputs >= 32. > > "been" -> "was" > > > LayoutTests/webaudio/audiochannelmerger-basic-expected.txt:8 > > +PASS ChannelMerger created successfully with empty parameter. > > ChannelMerger -> AudioChannelMerger Thanks, Fixed.

WebKit Review Bot

Comment 9 2012-04-13 18:25:48 PDT

Comment on attachment 137025 [details] Patch Clearing flags on attachment: 137025 Committed r114193: <http://trac.webkit.org/changeset/114193>

WebKit Review Bot

Comment 10 2012-04-13 18:25:52 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.