Bug 83737

Summary: Inline StringImpl::find(UChar, ...)
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: Web Template FrameworkAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Benjamin Poulain
Reported 2012-04-11 18:03:45 PDT
The overhead of having a function for StringImpl::find() is significant.
Attachments
Patch (7.11 KB, patch)
2012-04-11 18:18 PDT, Benjamin Poulain 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-04-11 18:18:08 PDT
Created attachment 136803 [details] Patch
Geoffrey Garen
Comment 2 2012-04-12 14:19:05 PDT
Comment on attachment 136803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136803&action=review r=me > Source/WTF/wtf/text/StringImpl.cpp:-780 > -size_t StringImpl::find(UChar c, unsigned start) It looks like this code sometimes used "index" and sometimes used "start" for this argument name. FWIW, I slightly prefer "start" over "index", since it's more precise. > Source/WTF/wtf/text/StringImpl.h:484 > + inline size_t find(UChar character, unsigned index = 0); No need for "inline" here.
Benjamin Poulain
Comment 3 2012-04-12 19:25:53 PDT
Committed r114071: <http://trac.webkit.org/changeset/114071>
Note You need to log in before you can comment on or make changes to this bug.