Bug 83728

Summary: Reduce the use of RenderLayer outside of the rendering code
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, jamesr, macpherson, menard, pnormand, simon.fraser, tkent, tonikitoo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 83811    
Attachments:
Description Flags
Proposed refactoring 1: Add 2 helpers functions, remove a third of the use, happily welcome comments on the naming.
none
Fixed Gtk / Qt by adding RenderObject.h include. One more round for the EWS. none

Julien Chaffraix
Reported 2012-04-11 16:06:20 PDT
A lot of the code outside rendering/ is talking directly to a RenderLayer where they shouldn't have such a deep knowledge of the rendering objects. This unfortunately propagates some rendering knowledge and assumptions outside the scope of rendering. It also ties our code to relying on RenderLayer for certain operations that reduces the abstraction.
Attachments
Proposed refactoring 1: Add 2 helpers functions, remove a third of the use, happily welcome comments on the naming. (25.52 KB, patch)
2012-04-11 16:26 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Fixed Gtk / Qt by adding RenderObject.h include. One more round for the EWS. (25.64 KB, patch)
2012-04-11 17:43 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2012-04-11 16:26:24 PDT
Created attachment 136784 [details] Proposed refactoring 1: Add 2 helpers functions, remove a third of the use, happily welcome comments on the naming.
Philippe Normand
Comment 2 2012-04-11 17:12:15 PDT
Comment on attachment 136784 [details] Proposed refactoring 1: Add 2 helpers functions, remove a third of the use, happily welcome comments on the naming. Attachment 136784 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12390125
Early Warning System Bot
Comment 3 2012-04-11 17:35:13 PDT
Comment on attachment 136784 [details] Proposed refactoring 1: Add 2 helpers functions, remove a third of the use, happily welcome comments on the naming. Attachment 136784 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12389211
Julien Chaffraix
Comment 4 2012-04-11 17:43:50 PDT
Created attachment 136799 [details] Fixed Gtk / Qt by adding RenderObject.h include. One more round for the EWS.
WebKit Review Bot
Comment 5 2012-04-12 09:02:42 PDT
Comment on attachment 136799 [details] Fixed Gtk / Qt by adding RenderObject.h include. One more round for the EWS. Clearing flags on attachment: 136799 Committed r113990: <http://trac.webkit.org/changeset/113990>
WebKit Review Bot
Comment 6 2012-04-12 09:02:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.