Bug 83699

Summary: V8 bindings are polluting WebCore namespace with overly generic FooInternal namespaces
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, eric, feature-media-reviews, haraken, japhet, kling, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Try to fix by hacking V8 generator blind
none
regenerated bindings test results abarth: review+

Antti Koivisto
Reported 2012-04-11 09:34:54 PDT
See the clash in https://bugs.webkit.org/show_bug.cgi?id=83612 between StyleSheetInternal class and a V8 binding namespace with the same name. V8 binding should have "V8" somewhere in the name to prevent name collisions.
Attachments
Try to fix by hacking V8 generator blind (3.92 KB, patch)
2012-04-11 09:42 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
regenerated bindings test results (75.00 KB, patch)
2012-04-11 10:48 PDT, Antti Koivisto 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2012-04-11 09:42:22 PDT
Created attachment 136679 [details] Try to fix by hacking V8 generator blind
Antti Koivisto
Comment 2 2012-04-11 10:48:59 PDT
Created attachment 136698 [details] regenerated bindings test results
Adam Barth
Comment 3 2012-04-11 10:54:15 PDT
Comment on attachment 136698 [details] regenerated bindings test results Interesting. Ok.
Antti Koivisto
Comment 4 2012-04-11 11:02:39 PDT
http://trac.webkit.org/changeset/113881
Note You need to log in before you can comment on or make changes to this bug.