Bug 83683

Summary: WebTextCheckerClient doesn't initialize output arguments.
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKit2Assignee: Simon Pena <spenap>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, commit-queue, dcheng, spenap, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Philippe Normand 2012-04-11 02:33:39 PDT 
Diff:

--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/editing/pasteboard/pasting-empty-html-falls-back-to-text-expected.txt 
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/editing/pasteboard/pasting-empty-html-falls-back-to-text-actual.txt 
@@ -1,5 +1,1 @@
 This test requires DRT. It verifies that pasting in a richly editable area falls back to text if the HTML content is an empty string.
-
-
-
-PASS

I'll mark it in test_expectations.
Comment 1 Simon Pena 2013-06-28 05:13:57 PDT 
This test now passes in Debug and Release in WebKitGTK, but crashes on Debug in WebKit2GTK.
Comment 2 Simon Pena 2013-07-02 06:03:40 PDT 
I am investigating this.
Comment 3 Simon Pena 2013-07-02 09:26:18 PDT 
The crash in GTK-WK2 happens in ASSERT(misspellingLocation < len), in TextCheckingHelper.cpp. I investigated how it happens, and it turned out that the values coming out of the IPC calls to checkSpellingOfString are wrong, and have not been initialized.

I am renaming this bug to something more appropriate and will upload a patch that fixes this.
Comment 4 Simon Pena 2013-07-02 09:32:17 PDT 
Created attachment 205922 [details]
Patch
Comment 5 Simon Pena 2013-07-02 09:48:07 PDT 
I am also taking a look at other places where this could be happening.
Comment 6 Simon Pena 2013-07-03 01:27:18 PDT 
CCing an OWNER for review as well.
Comment 7 Alexey Proskuryakov 2013-07-03 10:21:41 PDT 
Looks good to me.
Comment 8 WebKit Commit Bot 2013-07-03 11:06:45 PDT 
Comment on attachment 205922 [details]
Patch

Clearing flags on attachment: 205922

Committed r152369: <http://trac.webkit.org/changeset/152369>
Comment 9 WebKit Commit Bot 2013-07-03 11:06:49 PDT 
All reviewed patches have been landed.  Closing bug.