Bug 83671

Summary:

Methods in DOMCoreClasses.cpp not implemented in the Windows port (Nightly)

Product:

WebKit

Reporter:

George Tsoumalis <tsumalis96>

Component:

WebKit API

Assignee:

Nobody <webkit-unassigned>

Status:

UNCONFIRMED

Severity:

Major

CC:

adele, dglazkov, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
Patch for DOMCoreClasses.cpp	none
Revised patch for DOMCoreClasses.cpp	none
Diff Patch for DOMCoreClasses	none
Patch - Implementation for appendChild	none
Patch for appendChild in DOMCoreClasses.cpp	none
Patch for the appendChild() method in Node (DOMCoreClasses.cpp)	none
Patch for appendChild() in Node (DOMCoreClasses.cpp)	none
Patch for appendChild	none
Revised patch for appendChild	none
appendChild Implementation	webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-03	none
Patch for appendChild (revised)	none
2nd revised patch for appendChild()	none
Patch for appendChild (Revised)	adele: review-, tsumalis96: commit-queue?

George Tsoumalis

Reported 2012-04-11 00:29:17 PDT

I have tried to use several methods that DOMCoreClasses offer such as appendChild and setTextContent but I can't because they return E_NOTIMPL. I have seen that these methods have been implemented inside WebCore so I believe it should be easy to implement them also for the Windows port.

Attachments
Patch for DOMCoreClasses.cpp (14.99 KB, patch) 2012-04-12 06:34 PDT, George Tsoumalis	no flags	Details Formatted Diff Diff
Revised patch for DOMCoreClasses.cpp (14.91 KB, patch) 2012-04-12 07:20 PDT, George Tsoumalis	no flags	Details Formatted Diff Diff
Diff Patch for DOMCoreClasses (15.05 KB, patch) 2012-04-12 07:58 PDT, George Tsoumalis	no flags	Details Formatted Diff Diff
Patch - Implementation for appendChild (994 bytes, patch) 2012-04-14 04:52 PDT, George Tsoumalis	no flags	Details Formatted Diff Diff
Patch for appendChild in DOMCoreClasses.cpp (991 bytes, patch) 2012-04-14 05:00 PDT, George Tsoumalis	no flags	Details Formatted Diff Diff
Patch for the appendChild() method in Node (DOMCoreClasses.cpp) (1.53 KB, patch) 2012-04-17 01:53 PDT, George Tsoumalis	no flags	Details Formatted Diff Diff
Patch for appendChild() in Node (DOMCoreClasses.cpp) (1.66 KB, patch) 2012-04-17 02:05 PDT, George Tsoumalis	no flags	Details Formatted Diff Diff
Patch for appendChild (1.50 KB, patch) 2012-04-17 02:12 PDT, George Tsoumalis	no flags	Details Formatted Diff Diff
Revised patch for appendChild (1.62 KB, patch) 2012-04-17 02:18 PDT, George Tsoumalis	no flags	Details Formatted Diff Diff
appendChild Implementation (1.60 KB, patch) 2012-04-17 11:23 PDT, George Tsoumalis	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-03 (5.87 MB, application/zip) 2012-04-17 12:07 PDT, WebKit Review Bot	no flags	Details
Patch for appendChild (revised) (1.57 KB, patch) 2012-04-18 05:35 PDT, George Tsoumalis	no flags	Details Formatted Diff Diff
2nd revised patch for appendChild() (1.59 KB, patch) 2012-04-18 05:40 PDT, George Tsoumalis	no flags	Details Formatted Diff Diff
Patch for appendChild (Revised) (1.58 KB, patch) 2012-04-18 05:47 PDT, George Tsoumalis	adele: review- tsumalis96: commit-queue?	Details Formatted Diff Diff
Show Obsolete (12) View All Add attachment proposed patch, testcase, etc.

George Tsoumalis

Comment 1 2012-04-12 06:34:34 PDT

Created attachment 136892 [details] Patch for DOMCoreClasses.cpp

George Tsoumalis

Comment 2 2012-04-12 06:35:40 PDT

I tried to implement some of these methods but I don't know if they successfully work. Please provide me with information about where I have done something wrong so that I can successfully contribute to WebKit. Thanks in advance!

George Tsoumalis

Comment 3 2012-04-12 07:20:20 PDT

Created attachment 136905 [details] Revised patch for DOMCoreClasses.cpp

George Tsoumalis

Comment 4 2012-04-12 07:58:40 PDT

Created attachment 136914 [details] Diff Patch for DOMCoreClasses

George Tsoumalis

Comment 5 2012-04-14 04:52:29 PDT

Created attachment 137206 [details] Patch - Implementation for appendChild

George Tsoumalis

Comment 6 2012-04-14 05:00:22 PDT

Created attachment 137207 [details] Patch for appendChild in DOMCoreClasses.cpp

George Tsoumalis

Comment 7 2012-04-17 01:53:54 PDT

Created attachment 137489 [details] Patch for the appendChild() method in Node (DOMCoreClasses.cpp)

George Tsoumalis

Comment 8 2012-04-17 02:05:43 PDT

Created attachment 137491 [details] Patch for appendChild() in Node (DOMCoreClasses.cpp)

George Tsoumalis

Comment 9 2012-04-17 02:12:49 PDT

Created attachment 137493 [details] Patch for appendChild

George Tsoumalis

Comment 10 2012-04-17 02:18:33 PDT

Created attachment 137496 [details] Revised patch for appendChild

George Tsoumalis

Comment 11 2012-04-17 11:23:37 PDT

Created attachment 137565 [details] appendChild Implementation

WebKit Review Bot

Comment 12 2012-04-17 12:07:35 PDT

Comment on attachment 137565 [details] appendChild Implementation Attachment 137565 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12424087 New failing tests: svg/transforms/text-with-pattern-with-svg-transform.svg

WebKit Review Bot

Comment 13 2012-04-17 12:07:41 PDT

Created attachment 137577 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

George Tsoumalis

Comment 14 2012-04-18 05:35:29 PDT

Created attachment 137672 [details] Patch for appendChild (revised)

George Tsoumalis

Comment 15 2012-04-18 05:40:47 PDT

Created attachment 137673 [details] 2nd revised patch for appendChild()

George Tsoumalis

Comment 16 2012-04-18 05:47:34 PDT

Created attachment 137676 [details] Patch for appendChild (Revised)

Adele Peterson

Comment 17 2012-04-19 16:12:28 PDT

Comment on attachment 137676 [details] Patch for appendChild (Revised) There should be an automated test or this. Either you should add a new test that fails before this change and passes with it, or perhaps there are existing tests that are skipped on the Windows port that can now be unskilled.

Adele Peterson

Comment 18 2012-04-19 16:12:57 PDT

Meant to type "unskipped" (In reply to comment #17) > (From update of attachment 137676 [details]) > There should be an automated test or this. Either you should add a new test that fails before this change and passes with it, or perhaps there are existing tests that are skipped on the Windows port that can now be unskilled.

George Tsoumalis

Comment 19 2012-04-20 04:47:51 PDT

(In reply to comment #17) > (From update of attachment 137676 [details]) > There should be an automated test or this. Either you should add a new test that fails before this change and passes with it, or perhaps there are existing tests that are skipped on the Windows port that can now be unskilled. Thanks for the advice. Are there any resources to help me on how I should create tests? I think there are no current tests that test this kind of features.

Note You need to log in before you can comment on or make changes to this bug.