Summary: | [chromium] Signedness issue with code informing v8 of PatternSkia memory use | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Peter Kasting <pkasting> | ||||||
Component: | Platform | Assignee: | Adrienne Walker <enne> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | enne, jamesr, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Peter Kasting
2012-04-10 17:39:43 PDT
(In reply to comment #0) > P.S. Is there some way we could build WebKit with warnings=errors? Yes. Set the compile setting to warning=error, fix all the warnings that show up, and then check that in. Created attachment 136600 [details]
Patch
Comment on attachment 136600 [details]
Patch
OK
Created attachment 136603 [details]
Using using for std
Comment on attachment 136603 [details]
Using using for std
Really? We can't just std::-qualify things?
I have so much hatred for "using namespace".
Comment on attachment 136603 [details] Using using for std Right: http://www.webkit.org/coding/coding-style.html#using-in-cpp (In reply to comment #5) > (From update of attachment 136603 [details]) > Really? We can't just std::-qualify things? > > I have so much hatred for "using namespace". Tell me about it. You guys know more than I do, but I read that as forbidding "using std::XYZ" rather than forbidding just std::-qualifying the actual usages (and avoiding "using" altogether). Comment on attachment 136603 [details] Using using for std Clearing flags on attachment: 136603 Committed r113830: <http://trac.webkit.org/changeset/113830> All reviewed patches have been landed. Closing bug. |