Bug 83640

Summary: Add gesture event enums for long-press and pinch
Product: WebKit Reporter: Alexandre Elias <aelias>
Component: New BugsAssignee: Alexandre Elias <aelias>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aelias, andersca, dglazkov, fishd, jamesr, rjkroege, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alexandre Elias
Reported 2012-04-10 17:10:29 PDT
Add gesture event enums for long-press and pinch
Attachments
Patch (7.78 KB, patch)
2012-04-10 17:15 PDT, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexandre Elias
Comment 1 2012-04-10 17:15:52 PDT
Created attachment 136579 [details] Patch
WebKit Review Bot
Comment 2 2012-04-10 17:21:35 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Alexandre Elias
Comment 3 2012-04-10 17:21:54 PDT
This is just a small change to add gesture event enum values for these event types, currently doing nothing. We can gradually introduce support for them later.
James Robinson
Comment 4 2012-04-10 17:23:14 PDT
Comment on attachment 136579 [details] Patch R=me
WebKit Review Bot
Comment 5 2012-04-10 21:58:48 PDT
Comment on attachment 136579 [details] Patch Clearing flags on attachment: 136579 Committed r113826: <http://trac.webkit.org/changeset/113826>
WebKit Review Bot
Comment 6 2012-04-10 21:58:52 PDT
All reviewed patches have been landed. Closing bug.
Robert Kroeger
Comment 7 2012-04-11 06:52:07 PDT
Comment on attachment 136579 [details] Patch looks good to me.
Kent Tamura
Comment 8 2012-04-11 22:08:57 PDT
Don't you update WebViewImpl::handleInputEvent()?
Alexandre Elias
Comment 9 2012-04-12 17:15:56 PDT
(In reply to comment #8) > Don't you update WebViewImpl::handleInputEvent()? Oops, I missed that one. Anyway, it's harmless for now, let's fix it with the next CL that touches this code.
Note You need to log in before you can comment on or make changes to this bug.