Bug 83640

Summary: Add gesture event enums for long-press and pinch
Product: WebKit Reporter: Alexandre Elias <aelias>
Component: New BugsAssignee: Alexandre Elias <aelias>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aelias, andersca, dglazkov, fishd, jamesr, rjkroege, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Alexandre Elias 2012-04-10 17:10:29 PDT
Add gesture event enums for long-press and pinch
Comment 1 Alexandre Elias 2012-04-10 17:15:52 PDT
Created attachment 136579 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-10 17:21:35 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Alexandre Elias 2012-04-10 17:21:54 PDT
This is just a small change to add gesture event enum values for these event types, currently doing nothing.  We can gradually introduce support for them later.
Comment 4 James Robinson 2012-04-10 17:23:14 PDT
Comment on attachment 136579 [details]
Patch

R=me
Comment 5 WebKit Review Bot 2012-04-10 21:58:48 PDT
Comment on attachment 136579 [details]
Patch

Clearing flags on attachment: 136579

Committed r113826: <http://trac.webkit.org/changeset/113826>
Comment 6 WebKit Review Bot 2012-04-10 21:58:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Robert Kroeger 2012-04-11 06:52:07 PDT
Comment on attachment 136579 [details]
Patch

looks good to me.
Comment 8 Kent Tamura 2012-04-11 22:08:57 PDT
Don't you update WebViewImpl::handleInputEvent()?
Comment 9 Alexandre Elias 2012-04-12 17:15:56 PDT
(In reply to comment #8)
> Don't you update WebViewImpl::handleInputEvent()?

Oops, I missed that one.  Anyway, it's harmless for now, let's fix it with the next CL that touches this code.