Bug 83629

Summary:

Web Inspector: [Mac/WK1] explicitly allow file access for the Inspector's WebPreferences

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector (Deprecated)

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

ap, eric, joepeck, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed Change	timothy: review-, ap: commit-queue-
Proposed Change (Round 2)	ap: review+, timothy: commit-queue-

Timothy Hatcher

Reported 2012-04-10 15:30:49 PDT

We should explicitly allow file URL access from the Inspector so images can be used in canvases without security exceptions.

Attachments
Proposed Change (2.26 KB, patch) 2012-04-10 15:35 PDT, Timothy Hatcher	timothy: review- ap: commit-queue-	Details Formatted Diff Diff
Proposed Change (Round 2) (2.27 KB, patch) 2012-04-10 22:51 PDT, Timothy Hatcher	ap: review+ timothy: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2012-04-10 15:35:27 PDT

Created attachment 136558 [details] Proposed Change

Alexey Proskuryakov

Comment 2 2012-04-10 19:07:16 PDT

Comment on attachment 136558 [details] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=136558&action=review > Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:253 > + [preferences setAllowFileAccessFromFileURLs:NO]; > + [preferences setAllowUniversalAccessFromFileURLs:NO]; Something is wrong here - ChangeLog promises a YES.

Joseph Pecoraro

Comment 3 2012-04-10 22:44:16 PDT

Comment on attachment 136558 [details] Proposed Change Oh, you're totally right Alexey! Great catch. These should be YESes.

Timothy Hatcher

Comment 4 2012-04-10 22:51:01 PDT

Oops, I changed them to NO for tested and forgot to change them back!

Timothy Hatcher

Comment 5 2012-04-10 22:51:35 PDT

Created attachment 136624 [details] Proposed Change (Round 2)

Alexey Proskuryakov

Comment 6 2012-04-11 09:03:26 PDT

Comment on attachment 136624 [details] Proposed Change (Round 2) r=me. Please consider whether Inspector actually needs universal access from file URLs, or just file access.

Eric Seidel (no email)

Comment 7 2013-01-04 00:53:47 PST

Attachment 136624 [details] was posted by a committer and has review+, assigning to Timothy Hatcher for commit.

Timothy Hatcher

Comment 8 2013-01-04 06:39:28 PST

This wasn't needed.

Note You need to log in before you can comment on or make changes to this bug.