Bug 83599

Summary: Add TestNode.idl to run-binding-tests
Product: WebKit Reporter: Adam Klein <adamk>
Component: New BugsAssignee: Adam Klein <adamk>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, arv, haraken, japhet, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch abarth: review+

Adam Klein
Reported 2012-04-10 11:49:39 PDT
Add TestNode.idl to run-binding-tests
Attachments
Patch (43.73 KB, patch)
2012-04-10 11:51 PDT, Adam Klein 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Klein
Comment 1 2012-04-10 11:51:33 PDT
Created attachment 136497 [details] Patch
WebKit Review Bot
Comment 2 2012-04-10 11:55:16 PDT
Attachment 136497 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/bindings/scripts/test/ObjC/DOMTestNodeInternal.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Klein
Comment 3 2012-04-10 11:55:46 PDT
(In reply to comment #2) > Attachment 136497 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 > Source/WebCore/bindings/scripts/test/ObjC/DOMTestNodeInternal.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] > Total errors found: 1 in 14 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. This lint error is consistent with the rest of the ObjC test files.
Adam Klein
Comment 4 2012-04-10 12:23:58 PDT
Committed r113751: <http://trac.webkit.org/changeset/113751>
Note You need to log in before you can comment on or make changes to this bug.