Bug 83598

Summary: Remove unnecessary calls to RenderSVGShape::createShape
Product: WebKit Reporter: Philip Rogers <pdr>
Component: SVGAssignee: Philip Rogers <pdr>
Status: RESOLVED FIXED    
Severity: Normal CC: rhodovan.u-szeged, schenney, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Remove unnecessary calls to RenderSVGShape::createShape() none

Philip Rogers
Reported 2012-04-10 11:13:18 PDT
We call RenderSVGShape::createShape unnecessarily in RenderSVGShape::strokeContains. In the case of styled elements (Rect/RenderSVGRect and Ellipse/RenderSVGEllipse, for example), we will always call RenderSVGShape::createShape.
Attachments
Remove unnecessary calls to RenderSVGShape::createShape() (1.88 KB, patch)
2012-04-10 11:30 PDT, Philip Rogers 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philip Rogers
Comment 1 2012-04-10 11:30:37 PDT
Created attachment 136494 [details] Remove unnecessary calls to RenderSVGShape::createShape()
Rob Buis
Comment 2 2012-04-10 11:53:55 PDT
Comment on attachment 136494 [details] Remove unnecessary calls to RenderSVGShape::createShape() Looks redundant indeed.
WebKit Review Bot
Comment 3 2012-04-10 15:37:06 PDT
Comment on attachment 136494 [details] Remove unnecessary calls to RenderSVGShape::createShape() Clearing flags on attachment: 136494 Committed r113781: <http://trac.webkit.org/changeset/113781>
WebKit Review Bot
Comment 4 2012-04-10 15:37:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.