Bug 83595

Summary:

Grow row heights in tables to account for cell growth from pagination

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mitz: review+

Description Dave Hyatt 2012-04-10 10:37:15 PDT

Grow row heights in tables to account for cell growth from pagination instead of shrinking the cells and having their contents overflow. The pullback that results from this model just causes poor pagination slicing to occur.

Comment 1 Dave Hyatt 2012-04-10 10:37:41 PDT

In radar as:

<rdar://problem/10443278> Overlapping text in table cell across column break

Comment 2 Dave Hyatt 2012-04-10 10:42:19 PDT

Created attachment 136487 [details]
Patch

Comment 3 mitz 2012-04-10 10:44:44 PDT

Comment on attachment 136487 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136487&action=review

> LayoutTests/ChangeLog:11
> +        * fast/multicol/cell-shrinkback.html: Added.
> +        * platform/mac/fast/multicol/cell-shrinkback-expected.png: Added.
> +        * platform/mac/fast/multicol/cell-shrinkback-expected.txt: Added.

Can you try making this a reftest?

Comment 4 WebKit Review Bot 2012-04-10 10:46:02 PDT

Attachment 136487 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/WebCore/rendering/RenderTableSection.cpp:676:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.