Summary: | [BlackBerry] Crash when tearing down web page rendered using WebPageCompositor | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Arvid Nilsson <anilsson> | ||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | rwlbuis, tonikitoo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Arvid Nilsson
2012-04-10 05:32:44 PDT
Created attachment 136435 [details]
Patch
Comment on attachment 136435 [details]
Patch
so if the mlayerRenderer is null, "resources" were already released?
(In reply to comment #2) > (From update of attachment 136435 [details]) > so if the mlayerRenderer is null, "resources" were already released? Yes, or you could see it this way - the LayerRenderer owns the resources that should be released, so if there's no LayerRenderer, there are no resources to delete. Resources = textures right now, but could be more stuff in the future (for example shaders). Comment on attachment 136435 [details] Patch (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 136435 [details] [details]) > > so if the mlayerRenderer is null, "resources" were already released? > > Yes, or you could see it this way - the LayerRenderer owns the resources that should be released, so if there's no LayerRenderer, there are no resources to delete. Resources = textures right now, but could be more stuff in the future (for example shaders). Ok. I was wondering was would be the codepath be... (In reply to comment #4) > (From update of attachment 136435 [details]) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 136435 [details] [details] [details]) > > > so if the mlayerRenderer is null, "resources" were already released? > > > > Yes, or you could see it this way - the LayerRenderer owns the resources that should be released, so if there's no LayerRenderer, there are no resources to delete. Resources = textures right now, but could be more stuff in the future (for example shaders). > > Ok. I was wondering was would be the codepath be... Right now, it's probably due to an earlier call to WebPageCompositor::cleanup() that would clear the layer renderer. The layer rendrrer destructor then releases the resources. Comment on attachment 136435 [details] Patch Clearing flags on attachment: 136435 Committed r113757: <http://trac.webkit.org/changeset/113757> All reviewed patches have been landed. Closing bug. |