Summary: | [CMake] CMake SVG Code Generation fails to generate code for extra defines | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dominik Röttsches (drott) <d-r> | ||||||||
Component: | WebCore Misc. | Assignee: | Dominik Röttsches (drott) <d-r> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | eric, gyuyoung.kim, morrita, paroga, rakuco, rwlbuis, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 83564 | ||||||||||
Attachments: |
|
Description
Dominik Röttsches (drott)
2012-04-10 04:20:00 PDT
Also, meant to say that this should fix a couple of currently failing SVG tests that rely on SVG filters. Created attachment 136431 [details]
Fixing CMake build wrt SVG code generation
This should bring EFL test failures down by at least 17 cases.
Comment on attachment 136431 [details] Fixing CMake build wrt SVG code generation View in context: https://bugs.webkit.org/attachment.cgi?id=136431&action=review I agree with this patch. If you can reupload the patch with typo fix I can r+. > Source/WebCore/CMakeLists.txt:2584 > +# SVG extra defines need to map to a numerical value for correct preprocessing of svtags.in. svgtags.in > Source/WebCore/CMakeLists.txt:2590 > + LIST(APPEND SVG_EXTRA_DEFINES "ENABLE_SVG_FONTS=1") Does this add a space separator between both defines? CC'ing patrick. LGTM, since I have no better idea ATM Created attachment 136434 [details]
Fixing CMake build wrt SVG code generation
Thanks for the quick review, typo fixed.
(In reply to comment #3) > (From update of attachment 136431 [details]) > > > Source/WebCore/CMakeLists.txt:2590 > > + LIST(APPEND SVG_EXTRA_DEFINES "ENABLE_SVG_FONTS=1") > > Does this add a space separator between both defines? Yes it does. Comment on attachment 136434 [details] Fixing CMake build wrt SVG code generation View in context: https://bugs.webkit.org/attachment.cgi?id=136434&action=review > Source/WebCore/CMakeLists.txt:2585 > +SET(SVG_EXTRA_DEFINES, "") missed a point: comma after SVG_EXTRA_DEFINES Created attachment 136436 [details] Fixing CMake build wrt SVG code generation (In reply to comment #8) > (From update of attachment 136434 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=136434&action=review > > > Source/WebCore/CMakeLists.txt:2585 > > +SET(SVG_EXTRA_DEFINES, "") > > missed a point: comma after SVG_EXTRA_DEFINES Thanks. Fixed. Comment on attachment 136436 [details]
Fixing CMake build wrt SVG code generation
Looks fine. Should I cq+ too?
(In reply to comment #10) > (From update of attachment 136436 [details]) > Looks fine. Should I cq+ too? Yes please. Comment on attachment 136436 [details]
Fixing CMake build wrt SVG code generation
Looks fine. Should I cq+ too?
Thanks, Rob & Paroga! Comment on attachment 136436 [details] Fixing CMake build wrt SVG code generation Clearing flags on attachment: 136436 Committed r113763: <http://trac.webkit.org/changeset/113763> All reviewed patches have been landed. Closing bug. |