Bug 83554

Summary: DFG should flush SetLocals to arguments
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
oliver: review+
the patch
buildbot: commit-queue-
the patch barraclough: review+

Filip Pizlo
Reported 2012-04-10 01:18:53 PDT
This is necessary to match baseline JIT argument capture behavior.
Attachments
the patch (7.33 KB, patch)
2012-04-10 01:23 PDT, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
the patch (31.28 KB, patch)
2012-04-10 15:27 PDT, Filip Pizlo 		buildbot: commit-queue-
DetailsFormatted DiffDiff
the patch (31.38 KB, patch)
2012-04-10 15:46 PDT, Filip Pizlo 		barraclough: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-04-10 01:23:51 PDT
Created attachment 136412 [details] the patch
Geoffrey Garen
Comment 2 2012-04-10 08:30:10 PDT
<rdar://problem/11215848>
Filip Pizlo
Comment 3 2012-04-10 15:27:28 PDT
Created attachment 136557 [details] the patch
Build Bot
Comment 4 2012-04-10 15:36:19 PDT
Comment on attachment 136557 [details] the patch Attachment 136557 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12380546
Filip Pizlo
Comment 5 2012-04-10 15:46:38 PDT
Created attachment 136559 [details] the patch
Gavin Barraclough
Comment 6 2012-04-10 16:15:35 PDT
Comment on attachment 136559 [details] the patch ArgumentPosition isn't a position, so I'd suggest a different name, but since I don't have a better one, R+ either way.
Filip Pizlo
Comment 7 2012-04-10 17:37:43 PDT
Landed in http://trac.webkit.org/changeset/113796
Note You need to log in before you can comment on or make changes to this bug.