Bug 83546

Summary:

Optimize String.split() for 1 character separator

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

JavaScriptCore

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	barraclough: review+

Benjamin Poulain

Reported 2012-04-09 21:43:12 PDT

First stab at stringProtoFuncSplit().

Attachments
Patch (7.06 KB, patch) 2012-04-09 21:53 PDT, Benjamin Poulain	barraclough: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Benjamin Poulain

Comment 1 2012-04-09 21:53:55 PDT

Created attachment 136394 [details] Patch

Gavin Barraclough

Comment 2 2012-04-10 15:08:25 PDT

Comment on attachment 136394 [details] Patch Looks good, ooi is this a benchmark progression?

Benjamin Poulain

Comment 3 2012-04-10 22:11:32 PDT

(In reply to comment #2) > Looks good, ooi is this a benchmark progression? Yep, this helps in PeaceKeeper. I have the feeling I will need to improve the memory access to go further than this patch...

Benjamin Poulain

Comment 4 2012-04-11 12:09:40 PDT

Committed r113886: <http://trac.webkit.org/changeset/113886>

Note You need to log in before you can comment on or make changes to this bug.