Bug 83543

Summary: [chromium] Consistent checking for clipped rects when we need the computed result enclosed within the real result
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED FIXED    
Severity: Normal CC: backer, cc-bugs, enne, jamesr, piman, shawnsingh, skyostil, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Dana Jansens
Reported 2012-04-09 20:41:37 PDT
[chromium] Consistent checking for clipped rects when we need the computed result enclosed within the real result
Attachments
Patch (3.91 KB, patch)
2012-04-09 20:44 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.62 KB, patch)
2012-04-17 08:08 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.63 KB, patch)
2012-04-17 08:12 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-04-09 20:44:55 PDT
Created attachment 136388 [details] Patch
Dana Jansens
Comment 2 2012-04-09 20:46:04 PDT
I fixed the quad/bool naming in computeOcclusionBehindLayer that was copypaste from the old paint-specific code while I was in here.
Adrienne Walker
Comment 3 2012-04-16 11:15:26 PDT
Comment on attachment 136388 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136388&action=review R=me. Sounds reasonable to me. > Source/WebCore/ChangeLog:14 > + within the clipped result, and checking clipped explicitly maes this s/maes/makes/
Dana Jansens
Comment 4 2012-04-16 17:22:04 PDT
Committed r114324: <http://trac.webkit.org/changeset/114324>
Sami Kyostila
Comment 5 2012-04-17 04:24:23 PDT
(In reply to comment #4) > Committed r114324: <http://trac.webkit.org/changeset/114324> This only touches the changelog. Did I miss something?
Dana Jansens
Comment 6 2012-04-17 08:00:41 PDT
oh that's me learning about webkit-patch land's symantics... thank you for noticing !
Dana Jansens
Comment 7 2012-04-17 08:00:55 PDT
round 2
Dana Jansens
Comment 8 2012-04-17 08:08:25 PDT
Created attachment 137537 [details] Patch for landing
Dana Jansens
Comment 9 2012-04-17 08:12:12 PDT
Created attachment 137539 [details] Patch for landing
Dana Jansens
Comment 10 2012-04-17 08:14:56 PDT
even better, i had just failed at apply-from-bug. thanks again :)
WebKit Review Bot
Comment 11 2012-04-17 08:50:38 PDT
Comment on attachment 137539 [details] Patch for landing Clearing flags on attachment: 137539 Committed r114383: <http://trac.webkit.org/changeset/114383>
WebKit Review Bot
Comment 12 2012-04-17 08:50:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.