Bug 83543

Summary: [chromium] Consistent checking for clipped rects when we need the computed result enclosed within the real result
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED FIXED    
Severity: Normal CC: backer, cc-bugs, enne, jamesr, piman, shawnsingh, skyostil, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Description Dana Jansens 2012-04-09 20:41:37 PDT 
[chromium] Consistent checking for clipped rects when we need the computed result enclosed within the real result
Comment 1 Dana Jansens 2012-04-09 20:44:55 PDT 
Created attachment 136388 [details]
Patch
Comment 2 Dana Jansens 2012-04-09 20:46:04 PDT 
I fixed the quad/bool naming in computeOcclusionBehindLayer that was copypaste from the old paint-specific code while I was in here.
Comment 3 Adrienne Walker 2012-04-16 11:15:26 PDT 
Comment on attachment 136388 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136388&action=review

R=me.  Sounds reasonable to me.

> Source/WebCore/ChangeLog:14
> +        within the clipped result, and checking clipped explicitly maes this

s/maes/makes/
Comment 4 Dana Jansens 2012-04-16 17:22:04 PDT 
Committed r114324: <http://trac.webkit.org/changeset/114324>
Comment 5 Sami Kyostila 2012-04-17 04:24:23 PDT 
(In reply to comment #4)
> Committed r114324: <http://trac.webkit.org/changeset/114324>

This only touches the changelog. Did I miss something?
Comment 6 Dana Jansens 2012-04-17 08:00:41 PDT 
oh that's me learning about webkit-patch land's symantics... thank you for noticing !
Comment 7 Dana Jansens 2012-04-17 08:00:55 PDT 
round 2
Comment 8 Dana Jansens 2012-04-17 08:08:25 PDT 
Created attachment 137537 [details]
Patch for landing
Comment 9 Dana Jansens 2012-04-17 08:12:12 PDT 
Created attachment 137539 [details]
Patch for landing
Comment 10 Dana Jansens 2012-04-17 08:14:56 PDT 
even better, i had just failed at apply-from-bug. thanks again :)
Comment 11 WebKit Review Bot 2012-04-17 08:50:38 PDT 
Comment on attachment 137539 [details]
Patch for landing

Clearing flags on attachment: 137539

Committed r114383: <http://trac.webkit.org/changeset/114383>
Comment 12 WebKit Review Bot 2012-04-17 08:50:43 PDT 
All reviewed patches have been landed.  Closing bug.