Bug 83538

Summary: Don't let CSSPropertyWebkitPerspective dereference primitiveValue without null check.
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Luke Macpherson <macpherson>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, dbates, macpherson, menard, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Luke Macpherson
Reported 2012-04-09 19:11:21 PDT
Don't let CSSPropertyWebkitPerspective dereference primitiveValue without null check.
Attachments
Patch (1.82 KB, patch)
2012-04-09 19:14 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2012-04-09 19:14:04 PDT
Created attachment 136373 [details] Patch
Daniel Bates
Comment 2 2012-04-09 20:30:53 PDT
Comment on attachment 136373 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136373&action=review > Source/WebCore/ChangeLog:12 > + Coverity pointed out that we potentially dereference primitiveValue here without checking for null. > + I've added an early out for that case to make sure it can't ever happen. I don't know if it's actually > + possible to exercise that code path or not - probably the parser prevents it from being hit in practice. Have you tried writing a test?
Luke Macpherson
Comment 3 2012-04-09 20:53:59 PDT
I've read the parser code and can't see an obvious way to exercise this code path. I still think it's best to make the code obviously correct (and reduce false-positives coming from static analysis).
WebKit Review Bot
Comment 4 2012-04-09 21:48:10 PDT
Comment on attachment 136373 [details] Patch Clearing flags on attachment: 136373 Committed r113676: <http://trac.webkit.org/changeset/113676>
WebKit Review Bot
Comment 5 2012-04-09 21:48:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.